Repository navigation
List records under their schema names, with doc comments - #5
Merged
Merged
Conversation
The Studio method list uses a type's record id and doc comments when the generated types carry them, and falls back to derived names otherwise. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Studio method list derived every record name, because runtime types had none:
SignInResultshowed up asVerifySignInCodeResponse, and nested records were named after the field holding them. Doc comments from the schema were not shown at all.What changes
identity/identity.skir:SignInResult), so the same record has one definition wherever it is used.Requires
php-skir/runtime0.2.1 (php-skir/runtime#3). CI checks this branch against the runtime branch of the same name.