Repository navigation
ext/intl: Implement Collator::getRules() - #25222
Open
LamentXU123 wants to merge 1 commit into
Open
LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #24384 where I find the getRules function is also missing in Collator today.
This expose ucol_getRules to userland as Collator::getRules(). Returns the collator’s tailoring rules as a UTF-8 string or an empty string when no tailoring rules is there.
Note that I know there is also a ucol_getRulesEX, but per doc "ucol_getRules() should normally be used instead." we just use the original one. The EX version need us to allocate buffers for it.