Repository navigation
Conversation
mvorisek
force-pushed
the
verify_bundled_generator_script
branch
from
November 6, 2026 00:34
d0fb35d to
cda670f
Compare
Contributor
Author
|
@arnaud-lb would you mind to review and merge? |
arnaud-lb
reviewed
Nov 6, 2026
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
I don't really understand the benefits of this script. Generating adds complexity and reduces flexibility.
If we want to de-duplicate the steps in .github/workflows/verify-bundled-files.yml, maybe we can factor them in some way?
For the if condition:
env:
CHECK_ALL: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
steps:
- name: xxhash
if: ${{ !cancelled() && (steps.changes.outputs.xxhash == 'true' || env.CHECK_ALL == 'true') }}For the run script:
run: .github/scripts/download-and-verify.sh xxhash.sh xxhash.sh
Contributor
Author
|
I have addressed your feedback, thank you for it. About your question above - the workflow file needs the paths/names on several places and this is impossible to achieve by YAML grammar only without specifying it manually on several places. Even with few bundled sources now it saved me a lot of time and typos. And there are many more sources that can be added :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #19802
In the generator there is a manual how to use it.
The script allows:
.github/workflows/verify-bundled-files.yml) fully.github/scripts/download-bundled/*.shdownload scriptNo AI was used :)