Repository navigation
Split conferences and CFPs - #2058
Open
mattstauffer wants to merge 2 commits into
Open
mattstauffer wants to merge 2 commits into
mattstauffer wants to merge 2 commits into
Conversation
mattstauffer
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
November 10, 2026 18:41
On the /conferences/ page, split out views for conferences (for attendees) and CFPs (for speakers)
mattstauffer
force-pushed
the
mes/conferences-split
branch
from
November 10, 2026 18:44
9609c52 to
efc15aa
Compare
Contributor
|
📊 Regression report for commit efc15aa is at https://web-php-regression-report-pr-2058.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit efc15aa is available at https://web-php-pr-2058.preview.thephp.foundation |
Member
|
It doesn't seem to work in the preview: https://web-php-pr-2058.preview.thephp.foundation/conferences |
derickr
requested changes
Nov 11, 2026
derickr
left a comment
derickr
left a comment
Member
There was a problem hiding this comment.
I have some minor comments about the code, and no comments about the layout or approach.
…' text to differentiate conference vs. cfp
Contributor
Author
|
All concerns addressed @derickr -- thanks! |
Member
Yes, the conference resources seem to be synchronized from other places. There is no data here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the
/conferences/page, split out views for conferences (for attendees) and CFPs (for speakers).Also cleans up a few lines of CSS with inconsistent styling from the rest of
main.css