Repository navigation
feat(cli): print request IDs, log links and doc URLs on errors - #12
Conversation
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 75 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d9057cea6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0237bc0 to
009f42a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
API failures now include the request log and documentation links returned by the API.
Error:, followed byRequest ID:,Request log:, andDocs:when those values exist.--jsonerror envelope keepsschemaVersion: 1and adds optionalerror.requestLogUrlanderror.docUrlfields.The SDK dependency is the published npm version
@polymorfa/sdk@0.1.0-dev.20260922102711, pinned in bothpackage.jsonandpackage-lock.json. The previous unmerged SDK Git pin is no longer the dependency. The API error-body work is tracked in polymorfa/polymorfa#198; this CLI change does not establish its deployed availability.Six-part assessment
error.code,error.request_id,error.request_log_url, and top-leveldocs. No route, credential authority, scope, or server behavior changes here. Live deployment of the corresponding API behavior was not exercised.0.1.0-dev.20260922102711; this PR does not change the dependency manifest. Its installed transport confirms body-first request IDs, link parsing, and HTTP 413 classification.README.mddocuments output fields. Prepared internal launch copy adds CLI human/JSON output and redaction behavior to monorepodocs/api/errors.mdx. Publish that copy alongside the CLI release; date any changelog entry for confirmed availability.Verification
Verified CLI head:
009f42a266f590233f063c6e9b111e925b040bf6.Exact-head CI completed successfully. The checked-in workflow runs
npm ciandnpm run verifyon Node 22; verify includes formatting, lint, typecheck, tests, build, package dry-run, and production dependency audit.Independent exact-head archive: offline dependency installation, build, and 23 focused error/API tests passed on Node 24.15.0.
Focused assertions cover optional request/log/docs values, message-only output, and registered-secret redaction in both new URL fields. The command catch path supplies the registered secrets to the shared presenter before rendering human and JSON output.
Prepared error documentation examples exactly match the compiled presenter and JSON envelope at this head.
Not exercised: a live API deployment returning these fields or an installed released CLI. Publishing the prepared customer documentation alongside the CLI release and completing live release acceptance remain outstanding.