Repository navigation
feat(calls): make SIP trunks a standard feature - #17
Conversation
SIP trunks are a standard Calls feature, not a beta. Drop the beta wording from the sip-trunk command help, the calls settings set help, the topic description and the README.
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 82 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (6)
Comment |
|
@coderabbitai review |
|
Summary
Product-owner decision: SIP trunks are a standard Calls feature, not a beta. Monorepo change: polymorfa/polymorfa#208. SDK wording and contract pin: polymorfa/sdks#274.
This PR removes the beta wording from:
sip-trunk create,sip-trunk updateandsip-trunk rotate-credentialshelp;calls settings sethelp (the--inbound-route sip_trunksentence);sip-trunktopic description inpackage.json;No command, flag, default, output or exit behavior changed. There was no SIP-beta-specific error handling; generic
403handling is unchanged. The SDK dependency pin is unchanged because the SDK change is documentation only.Six-part assessment
calls-sip-trunksbeta key is retired in polymorfa/polymorfa#208. The CLI has no flag logic.Verification
npm run format:check,lint,typecheck,test(61 files, 486 passed),build,npm pack --dry-run --ignore-scriptsandaudit:prod(0 vulnerabilities) all pass.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.