Skip to content

feat(calls): make SIP trunks a standard feature - #17

Merged
purpshell merged 1 commit into
devfrom
t3code/sip-trunks-standard
Sep 19, 2026
Merged

purpshell merged 1 commit into
devfrom
t3code/sip-trunks-standard

Conversation

@purpshell

@purpshell purpshell commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Product-owner decision: SIP trunks are a standard Calls feature, not a beta. Monorepo change: polymorfa/polymorfa#208. SDK wording and contract pin: polymorfa/sdks#274.

This PR removes the beta wording from:

  • sip-trunk create, sip-trunk update and sip-trunk rotate-credentials help;
  • calls settings set help (the --inbound-route sip_trunk sentence);
  • the sip-trunk topic description in package.json;
  • the README "SIP trunks" section, which said changes fail with exit code 3 until the team enrolls.

No command, flag, default, output or exit behavior changed. There was no SIP-beta-specific error handling; generic 403 handling is unchanged. The SDK dependency pin is unchanged because the SDK change is documentation only.

Six-part assessment

Part Status
API Unaffected here. The change is in polymorfa/polymorfa#208 and only changes descriptions in the contract.
SDKs Updated in polymorfa/sdks#274. No re-pin is needed here.
CLI Updated (this PR): help text, topic description and README.
Docs Updated in polymorfa/polymorfa#208. The CLI README is updated here.
Feature releases The calls-sip-trunks beta key is retired in polymorfa/polymorfa#208. The CLI has no flag logic.
Admin controls Unaffected: the CLI exposes no admin operations.

Verification

npm run format:check, lint, typecheck, test (61 files, 486 passed), build, npm pack --dry-run --ignore-scripts and audit:prod (0 vulnerabilities) all pass.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

SIP trunks are a standard Calls feature, not a beta. Drop the beta wording
from the sip-trunk command help, the calls settings set help, the topic
description and the README.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 82 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 9b6aa276-cb11-4733-ac61-0af77040fa13

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb5f6d and 4361174.

📒 Files selected for processing (6)
  • README.md
  • package.json
  • src/commands/calls/settings/set.ts
  • src/commands/sip-trunk/create.ts
  • src/commands/sip-trunk/rotate-credentials.ts
  • src/commands/sip-trunk/update.ts

Comment @coderabbitai help to get the list of available commands.

@purpshell

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@purpshell
purpshell merged commit 5d0b039 into dev Sep 19, 2026
3 checks passed
@purpshell
purpshell deleted the t3code/sip-trunks-standard branch October 26, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant