Repository navigation
Stop sending email on behalf of users - #126
Merged
Merged
Conversation
Comments and reviews posted through the commitfest app were sent to the mailinglist with the user's own address as both the `From` header and the envelope sender. Our mail servers can't pass SPF or DKIM for the user's domain, so these emails bounced or ended up in spam for any domain with a strict DMARC policy, without the user ever finding out. This also caused a steady stream of delivery errors for pginfra. Instead of sending the email ourselves, the Comment and Review pages now link to the latest message of each thread in the archives, and explain how to use its "Resend email" button to get a copy of the message in your own inbox, so you can reply from your own email client. The review page also shows the usual review checklist, so people can still include it in their reply. The bulk emails that CF managers can send to authors and reviewers had the same problem. These are now sent from `NOTIFICATION_FROM`, with the manager's name in the display name and their address in `Reply-To`, so replies still go to them. Fixes #37
The separate page explaining how to reply through the archives was more verbose than needed. Now the Comment/Review dropdown and its route are removed, and each thread on the patch page gets a "reply" link to its latest message in the archives, with a tooltip explaining to use "Resend email" there.
The "reply" link pointed to the exact same archives URL as the "Latest at" link right before it, so it didn't add anything. The archives' "Resend email" requires a POST from the archives page itself, so we can't link to it directly either. Instead the help page now explains how to reply to a patch thread that isn't in your inbox.
With the Comment/Review form gone, there was nothing on the patch page anymore that tells people how to review a patch, which is mostly a problem for newcomers that aren't subscribed to the mailinglist. The new Review button opens a small dialog that links to the latest message of each thread in the archives, and explains how to use "Resend email" there to get a copy that you can reply to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments and reviews posted through the commitfest app were sent to the mailinglist with the user's own address as both the
Fromheader and the envelope sender. Our mail servers can't pass SPF or DKIM for the user's domain, so these emails bounced or ended up in spam for any domain with a strict DMARC policy, without the user ever finding out. This also caused a steady stream of delivery errors for pginfra.This removes the Comment/Review form entirely. Instead a new Review button on the patch page opens a small dialog that links to the latest message of each thread in the archives, and explains how to use "Resend email" there to get a copy you can reply to from your own email client. The help page explains the same.
The bulk emails that CF managers can send to authors and reviewers had the same problem. These are now sent from
NOTIFICATION_FROM, with the manager's name in the display name and their address inReply-To, so replies still go to them.Fixes #37