Repository navigation
model: replace the sample value type when decoding JSON - #1038
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
ViktorBystrov72
force-pushed
the
fix/reused-sample-json
branch
3 times, most recently
from
November 13, 2026 08:39
4cdbc93 to
968f4b9
Compare
Signed-off-by: Виктор Быстров <anatema@bk.ru>
ViktorBystrov72
force-pushed
the
fix/reused-sample-json
branch
from
November 14, 2026 05:45
968f4b9 to
4935451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a float sample into a
Samplethat previously held a histogram leaves the old histogram and timestamp in place. Reusing aVectortriggers the same problem becauseencoding/jsonreuses its sample pointers. For example, a histogram at timestamp 1 followed by a float value of 3 at timestamp 2 still marshals as the original histogram.Select the value type from the incoming JSON fields, and clear the previous representation when it changes. An object without a value field still preserves the existing sample, and null histograms remain invalid. Regression tests cover repeated histogram/float transitions for both an individual sample and a vector; they fail on the parent commit.
Validation:
make test GOOPTS=-racepassed with Go 1.27.3 and golangci-lint 2.14.0, including all root tests, lint, license, and module-tidy checks.git diff --checkpassed.@roidelapluie @gotjosh