Repository navigation
config: close request bodies when transport setup fails - #1041
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
ViktorBystrov72
force-pushed
the
fix/close-request-bodies-on-config-errors
branch
3 times, most recently
from
November 13, 2026 08:39
0a50acb to
f3616db
Compare
Signed-off-by: Виктор Быстров <anatema@bk.ru>
ViktorBystrov72
force-pushed
the
fix/close-request-bodies-on-config-errors
branch
from
November 14, 2026 05:45
f3616db to
1061c0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP transport wrappers return early when they cannot read credentials or header files, load TLS material, or construct a replacement transport. Those paths currently leave the request body open, contrary to the RoundTripper contract, which also requires closing it on errors. A body backed by a file or stream can therefore retain its resources after the request fails.
Close the body on errors that occur before delegating to the next transport. The regression tests cover authorization, both basic-auth credentials, file-backed headers, OAuth2 credentials and token TLS configuration, and three TLS reload failures. All nine cases fail on the parent implementation. Requests without a body are also covered.
Validation:
make test GOOPTS=-racepassed with Go 1.27.3 and golangci-lint 2.14.0, including root tests, lint, license, and module-tidy checks.git diff --checkpassed.@roidelapluie @gotjosh