Skip to content

Add pvlib.spa.transit_sunrise_sunset to documentation - #2873

Open
AdamRJensen wants to merge 5 commits into
pvlib:mainfrom
AdamRJensen:add_transit_sunrise_sunset_to_docs
Open

AdamRJensen wants to merge 5 commits into
pvlib:mainfrom
AdamRJensen:add_transit_sunrise_sunset_to_docs

Conversation

@AdamRJensen

Copy link
Copy Markdown
Member
  • Closes transit_sunrise_sunset: seems as a public function, not in public docs? #2255
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Add transit_sunrise_sunset function to documentation. See #2255.

@AdamRJensen AdamRJensen added this to the v0.16.2 milestone Sep 29, 2026
Comment thread pvlib/spa.py Outdated
Comment thread pvlib/spa.py Outdated
kandersolar and others added 2 commits October 26, 2026 18:20
Co-authored-by: Rajiv Daxini <143435106+RDaxini@users.noreply.github.com>
Comment thread pvlib/spa.py Outdated
Comment thread pvlib/spa.py Outdated
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@kandersolar

Copy link
Copy Markdown
Member

I would like to know why github is now showing the entire SPA file as one big change.

@echedey-ls

Copy link
Copy Markdown
Member

I would like to know why github is now showing the entire SPA file as one big change.

~/Documents/10_Programming/pvlib-python remotes/AdamRJensen/add_transit_sunrise_sunset_to_docs* ≡
❯ file pvlib/spa.py
pvlib/spa.py: Python script, Unicode text, UTF-8 text executable, with CRLF line terminators

You probably need to mitigate with https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings?platform=windows
The world would be a better place without windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transit_sunrise_sunset: seems as a public function, not in public docs?

5 participants