Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
from_formatbuilds its regex from the locale's month and weekday names and then looks the matched text up by exact value, so14nov22withDDMMMYYraisesString does not match formatwhile14Nov22works.This wraps the name tokens (
MMMM,MMM,dddd,ddd,dd) in a scoped(?i:...)group inFormatter._replace_tokens, and makesLocale.match_translationcompare lowercased values. Other tokens (T,Z,A) keep their current case rules.match_translationis only called fromfrom_formatparsing.Fixes #668 (also covers #809).
Ran live:
pendulum.from_format('14nov22','DDMMMYY')->2022-11-14 00:00:00+00:00(raised ValueError before).