Repository navigation
Build the Docker image in CI - #718
Merged
Merged
Conversation
Set up buildx and build the image on every push and pull request, so a Dockerfile that no longer builds fails here instead of at cabotage deploy time.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #718 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2182 2182
Branches 100 100
=========================================
Hits 2182 2182
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
dockerjob to the Tests workflow that sets up buildx and runsdocker build .on every push and pull request.The bot now deploys to PSF cabotage from this Dockerfile, so a Dockerfile that no longer builds should fail here, in CI, instead of at deploy time. This mirrors the Docker build step in the pyladiescon-portal CI.
The job needs no secrets and runs with the workflow's existing permissions, so it also runs on pull requests from forks.