You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Modernize the IDLE Find/Replace/Find in Files dialogs #67407
I've made some minor updates: Adding colons to the labels and right-justifying them. These updates can be seen in the second comparison screenshot.
roseman commented on Aug 2, 2015
rosemanmannequin
Mannequin
More actions
For illustration, attached idle_find_ttk.png, which is a minor layout tweak of the existing one (works on all the various find dialogs, though not shown in screen shot). I agree with Al's other suggestions here.
These changes all seem reasonable and have a nice look.
I have misgivings about shortening "regular expression" to "regex".
Otherwise, +1 for everything else.
roseman commented on Sep 25, 2015
rosemanmannequin
Mannequin
More actions
Have attached find-dialogs.patch, which does some cosmetic tweaks to the existing dialogs, as per the previous screenshot. It uses ttk widgets if available, and standard Tk widgets if not.
Relies on the ui.py module (not attached, as it is changing often).
AlSweigart commented on Nov 6, 2016
AlSweigartmannequin
MannequinAuthor
More actions
*Bump* Just wanted to bring attention to this issue. We could keep "Regular expression" instead of "Regex" for the label (Sublime Text and other editors have "Regular expression")
Further changes inspired by Notepad++, for a new issue with more than 1 PR.
The entry boxes are narrower than the adjacent button and not aligned. Make them the same size and aligned.
Change grid from 2 columns to three.
2a. Move [_] Regular expression down to its own line as, properly aligned, Search mode: [_] Regular expression.
2b. Replace direction radiobutton with checkbutton at the end ol the line above: [_] Search up.
Make these dialogs non-modal -- I believe there is already an issue for this.
Put the frames for the 3 dialogs onto 3 Notebook tabs in 1 window. Change title to match the selected tab.
Add more action buttons (Notepad++ has more). Discuss details on new issue.
Activity
AlSweigart commentedon Jan 10, 2015
Various changes to modernize the user interface of the Find, Replace, and Find in Files dialogs:
The attached png shows the before/after differences in the design of these dialogs.
AlSweigart commentedon Jan 18, 2015
I've made some minor updates: Adding colons to the labels and right-justifying them. These updates can be seen in the second comparison screenshot.
roseman commentedon Aug 2, 2015
For illustration, attached idle_find_ttk.png, which is a minor layout tweak of the existing one (works on all the various find dialogs, though not shown in screen shot). I agree with Al's other suggestions here.
rhettinger commentedon Aug 2, 2015
These changes all seem reasonable and have a nice look.
I have misgivings about shortening "regular expression" to "regex".
Otherwise, +1 for everything else.
roseman commentedon Sep 25, 2015
Have attached find-dialogs.patch, which does some cosmetic tweaks to the existing dialogs, as per the previous screenshot. It uses ttk widgets if available, and standard Tk widgets if not.
Relies on the ui.py module (not attached, as it is changing often).
AlSweigart commentedon Nov 6, 2016
*Bump* Just wanted to bring attention to this issue. We could keep "Regular expression" instead of "Regex" for the label (Sublime Text and other editors have "Regular expression")
I think Mark's patch would be better over mine.
terryjreedy commentedon Nov 7, 2016
Al, thanks for the honest comparison.
For 3.6, we can just import and use ttk with no fuss.
When I get to this, I will review tests and responses to <Return> and <Escape> (see bpo-27621).
terryjreedy commentedon Dec 27, 2023
#57795 (comment)
Put
[ Close ](cap 'C'0 at bottom. [Notepad++ has this.]Change
[ Find ]to[ Find next ]. [ditto]terryjreedy commentedon Oct 21, 2026
Further changes inspired by Notepad++, for a new issue with more than 1 PR.
Change grid from 2 columns to three.
2a. Move
[_] Regular expressiondown to its own line as, properly aligned,Search mode: [_] Regular expression.2b. Replace direction radiobutton with checkbutton at the end ol the line above:
[_] Search up.