Repository navigation
gh-159739: Fix reference and error handling in warnings - #159758
Merged
JelleZijlstra merged 4 commits intoOct 21, 2026
Merged
JelleZijlstra merged 4 commits into
JelleZijlstra merged 4 commits into
Conversation
Do not release the borrowed skip_file_prefixes argument, and stop if allocation of the fallback filename fails. Backport to 3.15 and 3.14.
Member
|
Verified this crash: |
gpshead
reviewed
Oct 19, 2026
gpshead
left a comment
Member
There was a problem hiding this comment.
consider a regression test?
class T(tuple): pass
for _ in range(3):
with self.module.catch_warnings(record=True):
self.module.warn("msg", skip_file_prefixes=T())
gpshead
reviewed
Oct 19, 2026
|
Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @jelle-openai and @JelleZijlstra, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-160022 is a backport of this pull request to the 3.15 branch. |
|
GH-160085 is a backport of this pull request to the 3.14 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 21, 2026
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not release the borrowed skip_file_prefixes argument, and stop if
allocation of the fallback filename fails.
Backport to 3.15 and 3.14.