Repository navigation
Conversation
corona10
requested review from
AA-Turner,
erlend-aasland and
serhiy-storchaka
as code owners
October 21, 2026 03:40
Member
Author
ZeroIntensity
approved these changes
Oct 21, 2026
Comment on lines
+51
to
+54
| SlotSpec('__next__', 'tp_iternext', 'PyObject *', 'object'), | ||
| ), | ||
| '__len__': ( | ||
| SlotSpec('__len__', 'sq_length', 'Py_ssize_t', 'Py_ssize_t'), |
Member
There was a problem hiding this comment.
Could you use keyword arguments instead of positional args here? I think it would make this more readable.
corona10
commented
Oct 21, 2026
| '__next__': ( | ||
| SlotSpec('__next__', 'tp_iternext', 'PyObject *', 'object'), | ||
| ), | ||
| '__len__': ( |
Member
Author
There was a problem hiding this comment.
For the __getitem__, it would be like this:
'__getitem__': (
# sq_item
SlotSpec( return_converter='object', parameters=(Py_ssize_t_converter,)),
# mp_subscript
SlotSpec(return_converter='object', parameters=(object_converter,)),
),
corona10
enabled auto-merge (squash)
October 21, 2026 04:06
corona10
disabled auto-merge
October 21, 2026 04:21
corona10
commented
Oct 21, 2026
| '__next__': SlotSpec('__next__', 'PyObject *', 'object', { | ||
| (): 'tp_iternext', | ||
| }), | ||
| '__next__': SlotSpec(return_type='PyObject *'), |
Member
Author
There was a problem hiding this comment.
Can you please take a look again? I simplify everything as possible.
Member
Author
There was a problem hiding this comment.
Yeah PTAL with the latest version.
I try to maintain consistency with other AC implementations as much as possible, while removing unnecessary guardrails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.