Skip to content

chore: Retire legacy Command installer Action (INF-4362) - #19

Merged
SagiMedina merged 2 commits into
mainfrom
feat/inf-4362-retire-command-action
Nov 3, 2026
Merged

SagiMedina merged 2 commits into
mainfrom
feat/inf-4362-retire-command-action

Conversation

@SagiMedina

Copy link
Copy Markdown
Collaborator

Composite action retains input names but never interpolates them, installs dependencies or runs prompts: a single explicit retirement error replaces execution. Release-notification workflow disabled/tombstoned. Approved-base static checks validate action/workflow contracts without executing proposed code.

2 static retirement checks.

Final local Qodo review failed obtaining repository credentials in current workspace; no retry or workspace switch. Independent peer review is required. Historical pinned Action refs cannot be rewritten; no tag/artifact deletion.

INF-4362. Managed backend retirement already landed in GitOps PR2401. This closes standard development paths; current QAR/SDK2/current CLI and retained records/artifacts are preserved.

@upwind-code-us

upwind-code-us Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Upwind Upwind Code Scan - ✅ Passed

0 newly introduced vulnerabilities · 0 resolved · 0 total in this PR vs main

View full analysis in Upwind Console

Scan completed in 12s

Scan history (1 scan)
Commit Scanned at New Resolved Net
c40effc < 2026-11-01 15:12 UTC 0 0 0

Last scanned: c40effc · 2026-11-01 15:12 UTC

@upwind-code-us

upwind-code-us Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Upwind Upwind IaC Scan - ✅ Passed

0 misconfigurations detected

No default-branch baseline yet — showing all findings.

View full analysis in Upwind Console →

Scan completed in 1s

Scan history (1 scan)
Commit Scanned at New Resolved Net
c40effc < 2026-11-01 15:12 UTC 0 0 0

Last scanned: c40effc · 2026-11-01 15:12 UTC

@SagiMedina
SagiMedina marked this pull request as ready for review November 1, 2026 15:49
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Retire the legacy Qodo Command Action and release notifications

⚙️ Configuration changes 🧪 Tests 📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Replace the legacy installer Action with an explicit retirement error while preserving input
 names.
• Disable release notifications and add static CI checks to prevent reactivating legacy workflows.
• Document the retirement boundary, current CLI, and limits of this main-branch change.
Diagram

graph TD
  Caller["Existing workflows"] --> Action["Retired action"] --> Failure["Retirement error"]
  Trigger["PR or push"] --> CI["Retirement checks"] --> Policy["Approved-base policy"] --> Validator["Static validation"]
  Validator -. inspects .-> Action
  Validator -. inspects .-> Slack["Notification tombstone"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Delete the Action and notification workflow
  • ➕ Removes the legacy entrypoints entirely.
  • ➖ Existing callers lose the explicit retirement diagnostic.
  • ➖ Deletion alone does not guard against reintroducing automation.
2. Use ordinary PR CI without an approved-base guard
  • ➕ Simpler workflow and checkout arrangement.
  • ➖ A proposed change could alter its own retirement checks.
  • ➖ Provides a weaker guarantee against reactivating legacy paths.

Recommendation: Keep the explicit-error tombstones and approved-base static guard: they give existing callers a clear failure and make main-branch reactivation harder. Review the fork checkout trust boundary before relying on the guard; the bootstrap check runs proposed test code with read-only permissions, and a live fork-triggered run has not yet been exercised. This change cannot alter historical pinned Action refs.

Files changed (6) +190 / -389

Documentation (1) +19 / -48
README.mdDocument legacy Action retirement and its boundaries +19/-48

Document legacy Action retirement and its boundaries

• Replaces installation and usage guidance with the retirement date, current CLI location, and status of historical refs. Explains the trusted CI inspection model and notes that a live fork-triggered run has not yet been exercised.

README.md

Other (5) +171 / -341
retirement-bootstrap.ymlAdd a bootstrap retirement check for proposed PR changes +21/-0

Add a bootstrap retirement check for proposed PR changes

• Runs the proposed static tests on pull requests or manual dispatch before the trusted policy is available on the base branch. Uses a pinned checkout with credentials persistence disabled and installs PyYAML in a temporary virtual environment.

.github/workflows/retirement-bootstrap.yml

retirement.ymlGuard retirement with approved-base static policy +33/-0

Guard retirement with approved-base static policy

• On pull-request-target, main pushes, and manual dispatch, checks out proposed and approved revisions separately. Runs isolated Python from the runner temporary directory using the approved test file to inspect proposed files, with read-only repository permissions and no persisted checkout credentials.

.github/workflows/retirement.yml

slack-notification.ymlTombstone release-notification automation +6/-219

Tombstone release-notification automation

• Removes the Pages trigger, Slack webhook delivery, and fallback notification path. Leaves a manual-only job that fails with an explicit retirement error and requests no permissions.

.github/workflows/slack-notification.yml

action.ymlReplace Command installation and execution with a failing diagnostic +21/-122

Replace Command installation and execution with a failing diagnostic

• Preserves the composite Action's input names while replacing dependency setup, package installation, and prompt execution with one retirement error and a nonzero exit. Inputs are no longer interpolated into shell commands.

action.yml

test_retirement.pyAdd static contracts for retired Action and workflows +90/-0

Add static contracts for retired Action and workflows

• Adds two tests that enforce the Action's exact failing step and restrict workflows to approved guard definitions or retired jobs. Proposed paths and symlinks are checked before reads; the tests parse YAML rather than execute proposed workflow or Action code.

tests/retirement/test_retirement.py

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Initial retirement checks can be bypassed 🐞 Bug ☼ Reliability
Description
retirement-bootstrap.yml runs the policy tests from the PR checkout, so a contributor can weaken
or remove those tests and still produce a passing bootstrap check. On this first PR, the
approved-base guard is not yet present on the base branch, leaving the proposed policy without an
independent automated check.
Code

.github/workflows/retirement-bootstrap.yml[R20-21]

+          /tmp/command-retirement-check/bin/pip install PyYAML==6.0.3
+          /tmp/command-retirement-check/bin/python -m unittest discover -s tests/retirement -v
Evidence
The bootstrap checkout has no base ref and executes test discovery from that checkout. The
assertions being run are themselves in the proposed test file; the separate workflow that executes
an approved-base copy is newly added and therefore cannot serve as a base-branch guard for the PR
introducing it.

.github/workflows/retirement-bootstrap.yml[14-21]
tests/retirement/test_retirement.py[83-86]
.github/workflows/retirement.yml[22-33]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The bootstrap check executes policy tests supplied by the same PR it validates. Until the approved-base guard exists on the base branch, a passing bootstrap result cannot establish that the retirement contracts were enforced.
## Fix Focus Areas
- .github/workflows/retirement-bootstrap.yml[14-21]
- .github/workflows/retirement.yml[22-33]
## Recommended Fix
Require independent approval of the initial retirement policy outside this self-validating check, and document that the bootstrap result is not an enforcement gate. For later PRs, rely on the approved-base guard to run trusted policy against proposed files.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can tweak Display settings with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment on lines +20 to +21
/tmp/command-retirement-check/bin/pip install PyYAML==6.0.3
/tmp/command-retirement-check/bin/python -m unittest discover -s tests/retirement -v

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Initial retirement checks can be bypassed 🐞 Bug ☼ Reliability

retirement-bootstrap.yml runs the policy tests from the PR checkout, so a contributor can weaken
or remove those tests and still produce a passing bootstrap check. On this first PR, the
approved-base guard is not yet present on the base branch, leaving the proposed policy without an
independent automated check.
Agent Prompt
## Issue description
The bootstrap check executes policy tests supplied by the same PR it validates. Until the approved-base guard exists on the base branch, a passing bootstrap result cannot establish that the retirement contracts were enforced.

## Fix Focus Areas
- .github/workflows/retirement-bootstrap.yml[14-21]
- .github/workflows/retirement.yml[22-33]

## Recommended Fix
Require independent approval of the initial retirement policy outside this self-validating check, and document that the bootstrap result is not an enforcement gate. For later PRs, rely on the approved-base guard to run trusted policy against proposed files.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@SagiMedina
SagiMedina merged commit e08f6fc into main Nov 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants