Skip to content

chore: add notable PostgreSQL bug fixes - #57

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
chore/release-notes-scout
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
chore/release-notes-scout

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated PostgreSQL release-notes scout.

tools/scrape_release_notes.py fetched the latest ~2 minor
release notes per major in {15,16,17,18}, filtered the
<li class="listitem"> entries by severity keywords, deduped
against data/known_bugs.json, and surfaced the top 5 per
major for review. The candidates are in proposed-bugs.json.

Action items for a human:

  • Decide which entries earn a permanent seat. The list
    is biased toward data-integrity / crash / replication
    bugs; doc-only or trivial entries should be dropped.
  • Rename curator IDs if needed (e.g. PG17-a1b2c3d4e
    → PG17-MERGE-RACE-CONDITION-01) before merging.
  • Merge selected entries into data/known_bugs.json:
    bash uv run python tools/scrape_release_notes.py --write --yes uv run python tools/generate_cve_sql.py git add data/known_bugs.json pgFirstAid.sql view_pgFirstAid.sql view_pgFirstAid_managed.sql git commit -m "chore: refresh known-bugs catalog"
  • Delete proposed-bugs.json before merge.

Notes on the keyword filter (HIGH/MEDIUM lists live in
tools/scrape_release_notes.py): the curated list is small,
intent is curated quality over recall, and silent false
negatives are preferred over noisy false positives. Tune the
keyword lists if the proposals get noisy or thin.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Refresh PostgreSQL release-note bug proposals for versions 15–18

✨ Enhancement 🕐 10-20 Minutes

Grey Divider

AI Description

• Replace the previous shortlist with 20 recent PostgreSQL bug-fix candidates across versions 15–18.
• Stage the candidates for human curation; the permanent catalog and generated SQL remain unchanged.
Diagram

graph TD
  A["PostgreSQL release notes"] --> B["Release-notes scout"] --> C["Proposed bugs"] --> D["Human review"] --> E["Known bugs catalog"]
  E -->|deduplication| B
Loading
High-Level Assessment

Keeping scraped fixes as proposals rather than automatically adding them to the permanent catalog is appropriate: keyword-ranked candidates still need relevance checks. Automatic publication would risk adding noisy entries, and this PR does not change the installed bug data.

Files changed (1) +80 / -80

Other (1) +80 / -80
proposed-bugs.jsonRefresh the 20-candidate PostgreSQL bug shortlist +80/-80

Refresh the 20-candidate PostgreSQL bug shortlist

• Replaces five proposals per major version with candidates from PostgreSQL 15.20, 16.16, 17.12, and 18.7. The entries carry candidate IDs, release-note summaries, links, and fixed minor versions for review; they are not added to the curated catalog.

proposed-bugs.json

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (3)

Grey Divider


Informational

1. Catalog entries would ship with footnote markers and author credits 🟡 P2 🐞 Bug
Description
The scraper's author-trimming regex in parse_release_page only matches a parenthesised name at the
very end of the summary, but these entries end in a § footnote marker, so the names stay in the
text. write then copies p["summary"] verbatim into known_bugs.json, so § and credits like
"(Richard Guo) §" reach the generated SQL views.
Code

proposed-bugs.json[10]

+    "summary": "Harden more memory-size calculations against integer overflow (Álvaro Herrera) § §",
Relevance

● Weak

Same trailing-§ author-trim defect in proposed-bugs.json was explicitly dismissed as false_positive
in PR #54 (recent).

PR-#54

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The proposal summary "Harden more memory-size calculations against integer overflow (Álvaro Herrera)
§ §" keeps both the author credit and the markers because the trim regex requires \)\s*$ and the
summary ends in §. The --write path at line 366 uses p["summary"] unchanged, so the same text
would be persisted. The same defect affects every summary in this file that ends with §.

proposed-bugs.json[10-10]
tools/scrape_release_notes.py[259-270]
tools/scrape_release_notes.py[366-366]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description: Release-note summaries keep `§` footnote markers and trailing author credits because the scraper trims the author only when the parenthesis is the last character. Those strings are then written verbatim into data/known_bugs.json.

Fix Focus Areas:
- tools/scrape_release_notes.py[259-270]
- tools/scrape_release_notes.py[366-366]

Recommended Fix: In parse_release_page, remove trailing `§` characters and whitespace from `summary` before the author-regex substitution, then run the author regex. Add a unit test covering a summary that ends in `(Name) §` and one ending in `§ §`. Clean the existing entries in proposed-bugs.json to match.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


View p2 (2)
2. Attributions to an unverified credit are proposed 🟡 P2 🐞 Bug
Description
The entries credit "Anthropic OSS program" as the author of two buffer-overrun fixes. The scraper
keeps the parenthesised text in the summary because its author regex only trims names that begin
with a capital letter.
Code

proposed-bugs.json[22]

+    "summary": "Fix buffer overrun in tsvector_delete() (Anthropic OSS program) §",
Relevance

●● Moderate

No precedent on verifying author credits; the only related dismissal concerned author text remaining
in summaries, not credit verification.

PR-#54

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The attribution appears in the scraped summary of "Fix buffer overrun in tsvector_delete()
(Anthropic OSS program) §" and of ts_rank_cd() at line 52. Nothing in the scraper checks this credit
against the upstream release notes, so it could be a scraping artifact or an unrelated string. The
curator should confirm both entries against upstream before they are merged.

proposed-bugs.json[22-22]
proposed-bugs.json[52-52]
tools/scrape_release_notes.py[267-267]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description: Two proposed entries credit "Anthropic OSS program", which the scraper did not validate against the upstream release notes.

Fix Focus Areas:
- proposed-bugs.json[22-22]
- proposed-bugs.json[52-52]

Recommended Fix: Open the PostgreSQL 17.12 and 18.7 release notes and confirm the credit for each entry. Correct or drop the entries if the credit does not appear upstream.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


3. Trivial memory-leak fix flagged as high severity 🟡 P2 🐞 Bug
Description
The HIGH_KEYWORDS list includes "memory leak", so _classify puts "Fix small memory leak in
pgoutput with streamed prepared transactions" in the high tier. The PR description asks curators to
drop trivial entries, but this one ranks above medium-tier crash-adjacent items.
Code

proposed-bugs.json[16]

+    "summary": "Fix small memory leak in pgoutput with streamed prepared transactions (Ayush Tiwari) §",
Relevance

●● Moderate

Severity-keyword misclassification was dismissed in PR #54, but that was a different entry and the
keyword-tier concern is subjective; no direct precedent.

PR-#54

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The proposal summary contains "memory leak", which matches a HIGH_KEYWORDS entry, so the item is
ranked as high severity and kept in the top-5 cap. Because the description says the list is biased
toward data-integrity and crash bugs, a "small" leak in a logical-replication plugin is a weak fit
for that tier.

proposed-bugs.json[16-16]
tools/scrape_release_notes.py[60-70]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description: A small memory-leak fix is classified as high severity by keyword matching and kept in the proposal set.

Fix Focus Areas:
- proposed-bugs.json[16-16]
- tools/scrape_release_notes.py[60-70]

Recommended Fix: Curators should drop this entry when reviewing. Consider removing the generic "memory leak" keyword from HIGH_KEYWORDS, or matching it only together with a crash or corruption keyword.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Compliance rules (platform): 1 rule
✅ Skills: none invoked
Review mode: Auto: 🚀 Fast: Localized catalog-only data update with no runtime behavior changes.

Grey Divider

Comment thread proposed-bugs.json
"doc_link": "https://www.postgresql.org/docs/release/15.19/",
"fixed_in_minor": 19
"issue_id": "PG15-3efcadec9",
"summary": "Fix buffer overrun in tsvector_delete() (Anthropic OSS program) §",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational

2. Attributions to an unverified credit are proposed 🐞 Bug ≡ Correctness

The entries credit "Anthropic OSS program" as the author of two buffer-overrun fixes. The scraper
keeps the parenthesised text in the summary because its author regex only trims names that begin
with a capital letter.
Agent Prompt
Issue description: Two proposed entries credit "Anthropic OSS program", which the scraper did not validate against the upstream release notes.

Fix Focus Areas:
- proposed-bugs.json[22-22]
- proposed-bugs.json[52-52]

Recommended Fix: Open the PostgreSQL 17.12 and 18.7 release notes and confirm the credit for each entry. Correct or drop the entries if the credit does not appear upstream.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

Comment thread proposed-bugs.json
"doc_link": "https://www.postgresql.org/docs/release/15.18/",
"fixed_in_minor": 18
"issue_id": "PG15-274da088e",
"summary": "Fix small memory leak in pgoutput with streamed prepared transactions (Ayush Tiwari) §",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational

3. Trivial memory-leak fix flagged as high severity 🐞 Bug ≡ Correctness

The HIGH_KEYWORDS list includes "memory leak", so _classify puts "Fix small memory leak in
pgoutput with streamed prepared transactions" in the high tier. The PR description asks curators to
drop trivial entries, but this one ranks above medium-tier crash-adjacent items.
Agent Prompt
Issue description: A small memory-leak fix is classified as high severity by keyword matching and kept in the proposal set.

Fix Focus Areas:
- proposed-bugs.json[16-16]
- tools/scrape_release_notes.py[60-70]

Recommended Fix: Curators should drop this entry when reviewing. Consider removing the generic "memory leak" keyword from HIGH_KEYWORDS, or matching it only together with a crash or corruption keyword.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants