Skip to content

Skip the iOS ScrollView clip walk when no view clips its subviews - #59284

Open
hryhoriiK97 wants to merge 1 commit into
react:mainfrom
hryhoriiK97:ios-skip-clip-walk-without-clipping
Open

hryhoriiK97 wants to merge 1 commit into
react:mainfrom
hryhoriiK97:ios-skip-clip-walk-without-clipping

Conversation

@hryhoriiK97

@hryhoriiK97 hryhoriiK97 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

RCTScrollViewComponentView updates clipped subviews in _remountChildren by calling updateClippedSubviewsWithClipRect:relativeToView: on its scroll view, after every mounting transaction and whenever the content offset has moved by more than kClippingLeeway while scrolling. The call walks every view in the scroll view's content. Only an RCTViewComponentView with removeClippedSubviews acts on it (it mounts and unmounts its children); every other view converts the rect and forwards it to its subviews.

Current behavior. removeClippedSubviews is off by default on iOS, so in most apps no view acts on the walk, but every ScrollView still runs it on every few points of scrolling. In RNTester, this walk is the largest main-thread cost while scrolling: from a sixth to almost half of the main thread's time on the screens below.

With this change. RCTViewComponentView keeps a count of live views with removeClippedSubviews on. It is updated when the prop changes, when a view is recycled and when it is deallocated, all on the main thread. _remountChildren returns early while the count is 0. When any view has removeClippedSubviews on, the walk runs as before. Turning the prop off doesn't depend on the walk either: the view remounts all its children as soon as the prop changes.

Changelog:

[IOS] [CHANGED] - A ScrollView no longer walks its content to update clipped subviews while no view has removeClippedSubviews on

Test Plan:

  • clang-format --dry-run --Werror on the changed files passes.
  • RCTViewComponentViewTests: all 24 tests pass on an iOS simulator. These tests are part of React-RCTFabric's test spec, which RNTester doesn't integrate, so I ran them by adding the file to the RNTesterUnitTests target locally (xcodebuild test -scheme RNTesterUnitTests -only-testing:RNTesterUnitTests/RCTViewComponentViewTests). The two new tests check that the count follows removeClippedSubviews across two views without counting a view twice, and that recycling and deallocating a clipping view take it off the count. With the decrement in dealloc removed, the second test fails.
  • RNTester built with xcodebuild in Release and run on a physical iPhone 15 Pro (iOS 26.6.1).
  • Same clipping. With a local check that kept walking on every call and, whenever the count was 0, confirmed that no visited view had removeClippedSubviews on, there were 0 mismatches over 102,997 walks (ScrollViewExample 89,199, TextExample 11,799, FlatList basic 1,999). In a screen that turns removeClippedSubviews on and off twice, with views mounted and unmounted in between, the count returned to 0 each time with 0 mismatches.
  • Measurement. The two arms are the same binary with the change switched by a launch argument, in the order before, after, after, before. Each launch opens the screen and does 5 flings down and 5 up, driven by Argent on the physical iPhone, under Instruments' Time Profiler. Values are the main thread's sampled time per launch, averaged over the 2 launches of each arm. iPhone 15 Pro, Release:
RNTester screen, no removeClippedSubviews before this PR change of which the walk (before)
TextExample 2,954 ms 1,342 ms −54.6% 1,326 ms
FlatList multicolumn 2,698 ms 1,498 ms −44.5% 1,144 ms
ScrollViewExample 2,426 ms 1,679 ms −30.8% 1,138 ms
FlatList basic 2,745 ms 1,963 ms −28.5% 791 ms
ScrollViewSimpleExample 1,362 ms 1,094 ms −19.7% 378 ms
SectionList scrollable 3,578 ms 3,356 ms −6.2% 572 ms

With the change, the walk took 0 ms on every screen. SectionList is mostly bound by the JS thread, and its main-thread total varied by ±10% between launches of the same arm.

RNTester Playground, 1000 cards inside a removeClippedSubviews view before (5 launches) this PR (6 launches) change
main thread per launch, average (range) 2,345 ms (2,151–2,428) 2,411 ms (2,338–2,449) within noise

With a clipping view present, both arms run the same walk and the only added work is one comparison per walk; the ranges overlap and the difference between launches comes from the flings.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 21, 2026

@javache javache left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of using global state for this.

The subview clip pass should be shallow and only consider the children of the scrollview itself. Could we track this locally inside the scrollview's (content view?)?

@hryhoriiK97

Copy link
Copy Markdown
Contributor Author

Thanks @javache! I tried tracking it on the content view, but the pass can't be shallow today: a View with removeClippedSubviews only adds new children to _reactSubviews, and the ScrollView's clip pass is what attaches them. So <ScrollView><View removeClippedSubviews>{rows}</View></ScrollView> relies on the deep pass, and skipping it would leave the rows empty.

Options:

  1. A per-ScrollView count instead of a global one (clipping views register with their nearest ScrollView).
  2. A shallow pass, with nested clipping Views attaching their own children.

Which would you prefer?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants