Repository navigation
test: save downloads outside /tmp/ferrum, which keeps the CI failure artifacts - #682
Merged
Merged
Conversation
…artifacts The download specs deleted /tmp/ferrum after saving a file there, taking the screenshots and CDP logs that spec_helper saves for failures in earlier spec files with it, so CI uploaded no artifacts for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec_helpersaves a screenshot and the CDP log of every failed example to/tmp/ferrum, and CI uploads that directory as an artifact.downloads_specand the:save_pathexample inbrowser_specalso saved files to/tmp/ferrumand then deleted the directory, taking the artifacts of failures in earlier spec files with it, so CI uploaded none for them.Downloads go to
/tmp/ferrum-downloadsnow, and/tmp/ferrumonly holds the failure artifacts.