Repository navigation
refactor(test): return Assert from ParkedChild::{kill,resume}() - #5203
Merged
Merged
Conversation
rami3l
force-pushed
the
test/parked-child-assert
branch
2 times, most recently
from
November 9, 2026 09:04
720fd61 to
3c49c21
Compare
rami3l
force-pushed
the
test/parked-child-assert
branch
from
November 9, 2026 09:04
3c49c21 to
07d7916
Compare
rami3l
marked this pull request as ready for review
November 9, 2026 09:05
djc
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #5194, this patch unifies the testing experience of regular subprocesses and
ParkedChildby making the latter return the sameAsserttype upon finish as the former.In other words, this allows returning code assertions and stdout/stderr snapshot testing on
ParkedChildas one would normally do with regular subprocesses.https://github.com/rust-lang/rustup/pull/5194/changes#diff-c6c864ad9d6d36c77a5ba7036d549e1c24a55bea1002c562f98e574db19240e9 gives an example that demonstrates how this can be helpful: