Repository navigation
fix: stop resetting umask during daemonization - #458
Open
ethanpailes wants to merge 1 commit into
Open
ethanpailes wants to merge 1 commit into
ethanpailes wants to merge 1 commit into
Conversation
This patch fixes daemonization to stop resetting the umask. We want to respect the umask that the shell the user is running `shpool attach` in set. Fixes #457
ethanpailes
force-pushed
the
fix-umask
branch
from
November 16, 2026 23:40
1ebfa63 to
45214a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
#457
AI Policy Ack
Ack
This PR was:
Description
This patch fixes daemonization to stop resetting the umask. We want to respect the umask that the shell the user is running
shpool attachin set.Fixes #457