Repository navigation
SK-3195 Note flowvault operations not yet in a published release - #466
Open
promptless[bot] wants to merge 1 commit into
Open
promptless[bot] wants to merge 1 commit into
promptless[bot] wants to merge 1 commit into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
![promptless[bot]](https://avatars.githubusercontent.com/in/979718?s=60&v=4){kind=small}
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 249 249
Lines 8799 8799
Branches 1268 1268
=======================================
Hits 8129 8129
Misses 446 446
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Adds a note to the flowvault README's Install section that some documented operations aren't in any published release yet.
Why
flowvault-release/26.10.1stack added Query, Get Tokens, Upload Files, and Delete Files. The README onmaindocuments all of them.1.3.0(tagflowvault/v1.3.0), doesn't contain any of these methods. A reader who copies the install snippet and then a Detect or Query example gets compile errors, and nothing in the README says why.Goal
1.3.0or earlier and tells readers to upgrade to the next release once it's on Maven Central.1.3.0; this note stays correct whether or not that merges first.Testing
flowvault/v1.3.0:VaultControllerhas noquery,getTokens,uploadFiles, ordeleteFilesmethod, and there's noDetectControllerorcom.skyflow.detectpackage.1.3.0is the latest version in Maven Central's metadata forcom.skyflow:skyflow-flowvault-java.flowvault/README.md.Trigger Events