Repository navigation
Fix various trino query things - #355
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bohreromir
changed the title
Bohreromir
marked this pull request as ready for review
October 6, 2026 16:58
Bohreromir
commented
Oct 6, 2026
…h-display # Conflicts: # src/lib/components/trino/StatementResult.svelte # src/lib/server/trino/result-collector.test.ts # src/lib/server/trino/result-collector.ts
Bohreromir
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
Bohreromir
moved this from Development: Done
to Development: Waiting for Review
in Stackable Engineering
Bohreromir
force-pushed
the
fix-trino-query-length-display
branch
from
October 14, 2026 12:27
88d3ffc to
835f8fa
Compare
…h-display # Conflicts: # src/lib/components/trino/StatementResult.svelte # src/routes/(app)/trino/+page.svelte
lfrancke
requested changes
Oct 20, 2026
lfrancke
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Trino can return a nextUri on the page that completes a result of exactly MAX_CLIENT_ROWS (e.g. `LIMIT 10000`), even when FINISHED, so that did not reliably indicate truncation. Keep polling until a row beyond the limit actually arrives, and keep rows already received instead of truncating them.
lfrancke
approved these changes
Oct 23, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
I'll leave it up to you.
So the check is correct now, but I believe we now show more rows to the user, righ? Potentially that is.
Let's say that last page brings me over the limit of 10000 then the UI will still show the warning that row limit is exceeded and something about 10k when we could display 11k or so.
Member
Author
|
Yes exactly. We only know if the query actually exceeds our max size by querying it, I thought its pointless to not show it to the user if we already got the data. Only querying further is stopped now. |
Bohreromir
enabled auto-merge
October 23, 2026 10:50
Bohreromir
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All in seperate commits, I hope its readable that way
Fixes:
Also reports the case of being over the row limit to the user