Repository navigation
Conversation
The Keycloak and Entra backends joined request-supplied user ids and names onto the base URL as text, so `/`, `?`, `#` and `..` in them changed which URL was requested. Both now append them as one percent-encoded path segment through `append_path_segments`, and the Keycloak backend sends the username as a query parameter. An empty, `.` or `..` segment and one containing a line break are rejected with `400`, as the url crate would drop or strip them and look up a different user. A Keycloak `rootPath` without a trailing slash is now kept, which `Url::join` dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Keycloak and Entra backends joined request-supplied user ids and names onto the base URL as text, so
/,?,#and..in them changed which URL was requested. It was all spec compliant but just not the expected behavior when we just want "simple" joining of URL segments. Both now append them as one percent-encoded path segment throughappend_path_segments, and the Keycloak backend sends the username as a query parameter.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker