Repository navigation
docs(all): add AGENTS.md and update development guide - #203
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
fefi95
marked this pull request as ready for review
October 16, 2026 15:13
rojasTob
approved these changes
Nov 6, 2026
rojasTob
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @fefi95, this is a solid PR. I checked every reference in AGENTS.md against the branch:
- Paths:
expect.ts,usePlugin→config.addPlugin,Config.ts,release.ymlall exist where it says. - Matcher and test snippets: they match
NumberAssertion.tsand its test file line for line. - Merge setting: the repo really is squash-only.
- Links: the
#requirementsand#scopesanchors work. - Scopes: the table matches the four packages and their
.releaserc.jsonrules.
The corepack note for Node 25 is a good catch.
Verdict: Approve. A few small, non-blocking notes:
CLAUDE.mdis missing. #190 asks for aCLAUDE.mdthat points toAGENTS.md. As far as I know, Claude Code only readsCLAUDE.md, so Claude agents won't pick this file up on their own. A one-lineCLAUDE.mdcontaining@AGENTS.mdwould fix that and close #190 as written.- The "Test rule" wording reads as if the gap is fixed, but it isn't. It says the suite once let a
>→>=mutation pass. The.toBeGreaterThantests still only use 3 vs 2 and 1 vs 2, with no equal-value case, so that mutation would still pass today. Either add the boundary case here or say "currently" instead of "once". - Related bug, for a separate issue.
toBeOddusesthis.actual % 2 === 1. Since-3 % 2 === -1,expect(-3).toBeOdd()fails. This is exactly the problem the new rule warns about, and the tests don't cover negative numbers. I'd open a follow-up rather than fix it in this PR. - Nit:
corepack enablenow appears both in Requirements and in the install block. That's fine, just slightly repetitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190
Closes #194
Verified (Node 25.2.1 from
.nvmrc, fresh clone, cold cache)npm install -g corepack && corepack enableyarn --version→ 4.1.0yarn install --immutableyarn compile/yarn lint/yarn testyarn compile && yarn lint && yarn testyarn checkcd packages/core && yarn testyarn why taryarn npm audit --all --recursive --severity high@isaacs/brace-expansion); exit 0 means cleanyarn dedupe tar --checkWhere the code disagreed with the issues
.nvmrcpins 25.2.1, which no longer bundles Corepack, so a barecorepack enablefails.development.mdaddsnpm install -g corepackfor Node 25+.development.mdtable (plus per-package.releaserc.jsonrules), soAGENTS.mdlinks to that table.usePlugin(): it is defined inpackages/core/src/main.tsand callsconfig.addPlugininconfig/Config.ts.AGENTS.mddescribes both.yarn lintprints react-native parse warnings but exits 0;AGENTS.mdsays to trust the exit code.--severity high(per task) and noted the exit code.AGENTS.mdis the only agent file on purpose: it is the cross-tool convention, and #190's original title also mentionedCLAUDE.md.