Skip to content

fix: upgrade weak hash in renamefile.py (CWE-328) - #808

Closed
anupamme wants to merge 1 commit into
stashapp:mainfrom
anupamme:fix-repo-communityscripts-renamefile-md5-cwe-328
Closed

anupamme wants to merge 1 commit into
stashapp:mainfrom
anupamme:fix-repo-communityscripts-renamefile-md5-cwe-328

Conversation

@anupamme

@anupamme anupamme commented Nov 1, 2026

Copy link
Copy Markdown

MD5 is used to generate the suffix for truncated filenames. MD5 is collision-prone, but the validated attack scenario requires an attacker to influence scene metadata and arrange a collision in the same directory. This makes practical exploitation less likely than the severity label alone suggests. The affected code is plugins/RenameFile/renamefile.py:390. This change is the fix I would apply.

Reference: CWE-328

What changed

  • plugins/RenameFile/renamefile.py

Verification

No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.


Automated security fix by OrbisAI Security

Automated security fix generated by OrbisAI Security
@DogmaDragon DogmaDragon added the type:plugin Plugins label Nov 1, 2026
@DogmaDragon DogmaDragon closed this Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants