Repository navigation
test(init): assert the two-line onboarding trailer - #566
Merged
Merged
Conversation
…ed beside it #559 changed the trailer while two tests asserting the old sentence were landing on main, so main went red after the stack merged. The telemetry test now compares its last console.log entry with getOnboardTrailer(), and the commit-banner ordering test looks for ONBOARD_PROMPT.
theCodeDrift
force-pushed
the
552-fix-trailer-tests
branch
from
October 21, 2026 08:54
b03abfd to
5bd720e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red after #559 and #563 landed (Validate run 39571233594 on f8e062c). Two tests that merged while that stack was open still asserted the old one-sentence trailer:init-telemetry-notice.test.ts: expected the lastconsole.logentry to match/^In your AI tool, /. The trailer is now one two-lineconsole.logcall, so the test compares that entry withgetOnboardTrailer()itself, which holds at any colour level.init-no-interactive.test.ts(commit-before-your-agent banner): looked forask to onboard with Tasklessto check the banner prints above the trailer. It now looks forONBOARD_PROMPT.Test-only; no product change. Both orderings the tests protect (telemetry notice before the trailer, commit banner above it) still hold. Full CLI suite passes locally (137 files, 2577 tests), along with typecheck and lint.
Refs #552