Skip to content

Add Nexus serialization context to RespondNexusTask requests - #909

Draft
Vaughan-Temporal wants to merge 1 commit into
mainfrom
vaughan/nexus-reply-serialization-context
Draft

Vaughan-Temporal wants to merge 1 commit into
mainfrom
vaughan/nexus-reply-serialization-context

Conversation

@Vaughan-Temporal

Copy link
Copy Markdown

What changed?
Added propagated_nexus_serialization_context (nexus.v1.PropagatedSerializationContext) to RespondNexusTaskCompletedRequest (field 6) and RespondNexusTaskFailedRequest (field 7).

Why?
SDKs encode sync Nexus results and handler failures with the operation's serialization context, but the reply doesn't say which one. #872 added the context to workflow starts, activity polls and outcome reads; this adds it to the sync Nexus reply. That lets a component in front of the frontend that encodes payloads per Nexus endpoint key the reply without tracking task tokens.

The SDK takes it from PollNexusTaskQueueResponse.request (endpoint) and the start/cancel variant (service, operation), and leaves it unset when the poll carried no endpoint. The server passes it through unread: frontend embeds the request unchanged in the matching request, and nothing validates or routes on it.

Breaking changes
None. New optional fields.

Server PR
None needed.

Add propagated_nexus_serialization_context to RespondNexusTaskCompletedRequest
and RespondNexusTaskFailedRequest, so a Nexus task reply names the endpoint,
service and operation its payloads were encoded for, as workflow starts and
activity task polls already do.
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants