Repository navigation
Add Nexus serialization context to RespondNexusTask requests - #909
Draft
Vaughan-Temporal wants to merge 1 commit into
Draft
Vaughan-Temporal wants to merge 1 commit into
Vaughan-Temporal wants to merge 1 commit into
Conversation
Add propagated_nexus_serialization_context to RespondNexusTaskCompletedRequest and RespondNexusTaskFailedRequest, so a Nexus task reply names the endpoint, service and operation its payloads were encoded for, as workflow starts and activity task polls already do.
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
propagated_nexus_serialization_context(nexus.v1.PropagatedSerializationContext) toRespondNexusTaskCompletedRequest(field 6) andRespondNexusTaskFailedRequest(field 7).Why?
SDKs encode sync Nexus results and handler failures with the operation's serialization context, but the reply doesn't say which one. #872 added the context to workflow starts, activity polls and outcome reads; this adds it to the sync Nexus reply. That lets a component in front of the frontend that encodes payloads per Nexus endpoint key the reply without tracking task tokens.
The SDK takes it from
PollNexusTaskQueueResponse.request(endpoint) and the start/cancel variant (service, operation), and leaves it unset when the poll carried no endpoint. The server passes it through unread: frontend embeds the request unchanged in the matching request, and nothing validates or routes on it.Breaking changes
None. New optional fields.
Server PR
None needed.