Repository navigation
Bump envconfig to v1.1.0 with minimum compatible server dependencies - #1275
Open
chaptersix wants to merge 2 commits into
Open
chaptersix wants to merge 2 commits into
chaptersix wants to merge 2 commits into
Conversation
chaptersix
marked this pull request as ready for review
November 16, 2026 20:49
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9682eecab0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chaptersix
enabled auto-merge
November 16, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Upgrade envconfig to v1.1.0 in both Go modules to include nested
unknown profile-field support and the TOML key-iteration fix.
Use SDK v1.49.0 and server v1.33.0-166.3. The v166 release line is
the first whose API dependency meets envconfig's v1.64.0 requirement.
Pin the root API dependency to the server's declared version:
v1.64.1-0.20261030195137-01272cbd37c9.
Align both modules to Go 1.27.3, use the server's worker dependency,
and adapt activity start options to the SDK's StaticDetails field.
No config-command changes from #1271 are included.
How did you test this?
No tests added or changed. Envconfig v1.1.0 includes regression
coverage for nested unknown fields, TOML round trips, and conflicts
with modeled fields.