Repository navigation
Add opt-in user group memberships to user APIs - #143
Merged
Merged
Conversation
nikki-dag
marked this pull request as ready for review
November 13, 2026 20:51
nikki-dag
requested review from
anekkanti
and
a balanced review from Copilot
November 13, 2026 20:52
There was a problem hiding this comment.
🔵 Needs a closer look
Inaccessible backend and proto PRs require human confirmation of wire compatibility, backend deployment, and opt-in and full-identity authorization enforcement before publication.
No open issues 🎉
What changed in this PR
Adds opt-in group membership data to the Cloud Ops user APIs, allowing identity-governance integrations to retrieve memberships alongside user details.
Changes:
- Adds
include_group_membershipstoGetUserandGetUsers, defaulting tofalse. - Adds group IDs and display names to
User.group_memberships, without roles or permissions and subject to existing full-identity access restrictions. - Updates the public API version to
v0.27.0; publication depends on backend deployment and coordination with PR #142’s version bump.
| File | Description |
|---|---|
| VERSION | Bumps the API version to v0.27.0. |
| temporal/api/cloud/identity/v1/message.proto | Defines user group membership data and documents visibility restrictions. |
| temporal/api/cloud/cloudservice/v1/request_response.proto | Adds opt-in membership flags to both user retrieval requests. |
| README.md | Updates the documented API version to v0.27.0. |
Review effort: Balanced
jeri-temporal
approved these changes
Nov 13, 2026
anekkanti
reviewed
Nov 13, 2026
anekkanti
approved these changes
Nov 13, 2026
nikki-dag
force-pushed
the
nikki/oncas-368-user-group-memberships
branch
from
November 16, 2026 20:09
7678829 to
4eb7324
Compare
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add
include_group_membershipsto GetUser and GetUsers, plusUser.group_membershipscontaining group IDs and display names. Field numbers and message definitions match temporalio/saas-proto#1434, released insaas-proto v0.949.0.Why?
Identity-governance integrations need a user's group memberships in the same response. Memberships are opt-in, contain no group roles or permissions, and follow the existing full identity access restrictions.
Checklist
Closes: N/A. Backend implementation: temporalio/saas-control-plane#16950; deploy it before publishing this API release.
How was this tested:
git diff --checkand CImake ci-buildpassed (Buf lint, breaking-change checks, Go/gRPC/OpenAPI generation). Read-only production checks usingv0.27.0verified GetUser opt-in returns group IDs/names matching GetUserGroup, default omission on both endpoints, identity-access restrictions, email filtering, and list pagination. Populated GetUsers memberships still need an account-admin check; the caller's non-admin list responses correctly withhold full identity information.Any docs updates needed? Field comments are included. Main already includes the v0.27.0 bump from Add project-scoped custom roles and release v0.27.0 #142. Remove the matching
temporal:devannotations in saas-proto after public publication.Note
Medium Risk
Expands identity API surface and can expose group membership metadata; access remains gated by existing full-identity rules and is opt-in.
Overview
Adds an opt-in way to return SCIM and Cloud group memberships when fetching users, without exposing group roles or permissions.
GetUserandGetUsersgain optionalinclude_group_memberships(defaults to false). When enabled and the caller can view full identity, eachUsermay includegroup_memberships: a list ofUserGroupMembershipentries withgroup_idanddisplay_nameonly.This is an additive API change for identity-governance integrations that need membership in the same call as user listing/detail.
Reviewed by Cursor Bugbot for commit 4eb7324. Bugbot is set up for automated code reviews on this repo. Configure here.