Skip to content

Add opt-in user group memberships to user APIs - #143

Merged
nikki-dag merged 1 commit into
mainfrom
nikki/oncas-368-user-group-memberships
Nov 16, 2026
Merged

nikki-dag merged 1 commit into
mainfrom
nikki/oncas-368-user-group-memberships

Conversation

@nikki-dag

@nikki-dag nikki-dag commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

Add include_group_memberships to GetUser and GetUsers, plus User.group_memberships containing group IDs and display names. Field numbers and message definitions match temporalio/saas-proto#1434, released in saas-proto v0.949.0.

Why?

Identity-governance integrations need a user's group memberships in the same response. Memberships are opt-in, contain no group roles or permissions, and follow the existing full identity access restrictions.

Checklist

  1. Closes: N/A. Backend implementation: temporalio/saas-control-plane#16950; deploy it before publishing this API release.

  2. How was this tested: git diff --check and CI make ci-build passed (Buf lint, breaking-change checks, Go/gRPC/OpenAPI generation). Read-only production checks using v0.27.0 verified GetUser opt-in returns group IDs/names matching GetUserGroup, default omission on both endpoints, identity-access restrictions, email filtering, and list pagination. Populated GetUsers memberships still need an account-admin check; the caller's non-admin list responses correctly withhold full identity information.

  3. Any docs updates needed? Field comments are included. Main already includes the v0.27.0 bump from Add project-scoped custom roles and release v0.27.0 #142. Remove the matching temporal:dev annotations in saas-proto after public publication.


Note

Medium Risk
Expands identity API surface and can expose group membership metadata; access remains gated by existing full-identity rules and is opt-in.

Overview
Adds an opt-in way to return SCIM and Cloud group memberships when fetching users, without exposing group roles or permissions.

GetUser and GetUsers gain optional include_group_memberships (defaults to false). When enabled and the caller can view full identity, each User may include group_memberships: a list of UserGroupMembership entries with group_id and display_name only.

This is an additive API change for identity-governance integrations that need membership in the same call as user listing/detail.

Reviewed by Cursor Bugbot for commit 4eb7324. Bugbot is set up for automated code reviews on this repo. Configure here.

@nikki-dag
nikki-dag marked this pull request as ready for review November 13, 2026 20:51
@nikki-dag
nikki-dag requested a review from a team as a code owner November 13, 2026 20:51
@nikki-dag
nikki-dag requested review from anekkanti and a balanced review from Copilot November 13, 2026 20:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Inaccessible backend and proto PRs require human confirmation of wire compatibility, backend deployment, and opt-in and full-identity authorization enforcement before publication.

No open issues 🎉

What changed in this PR

Adds opt-in group membership data to the Cloud Ops user APIs, allowing identity-governance integrations to retrieve memberships alongside user details.

Changes:

  • Adds include_group_memberships to GetUser and GetUsers, defaulting to false.
  • Adds group IDs and display names to User.group_memberships, without roles or permissions and subject to existing full-identity access restrictions.
  • Updates the public API version to v0.27.0; publication depends on backend deployment and coordination with PR #142’s version bump.
File Description
VERSION Bumps the API version to v0.27.0.
temporal/​api/​cloud/​identity/​v1/​message.proto Defines user group membership data and documents visibility restrictions.
temporal/​api/​cloud/​cloudservice/​v1/​request_response.proto Adds opt-in membership flags to both user retrieval requests.
README.md Updates the documented API version to v0.27.0.

Review effort: Balanced

@nikki-dag
nikki-dag force-pushed the nikki/oncas-368-user-group-memberships branch from 7678829 to 4eb7324 Compare November 16, 2026 20:09
@nikki-dag
nikki-dag merged commit be616d7 into main Nov 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants