Repository navigation
Conversation
khisakuni
previously approved these changes
Nov 3, 2026
david049
force-pushed
the
dliu/addsaaexportdisable
branch
from
November 17, 2026 19:51
0b069bf to
e05a976
Compare
david049
requested a deployment
to
integration
November 17, 2026 19:51 — with
GitHub Actions
Waiting
david049
requested a deployment
to
integration
November 17, 2026 19:51 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds support for disabling standalone activity export
Why?
Checklist
Closes
How was this tested:
Note
Medium Risk
Changes what events are exported to customer-owned sinks and refactor export command paths; mis-handling the filter on update could silently change export behavior.
Overview
Adds
--disable-standalone-activity-exportto S3, GCS, and Azure Blob namespace export sink create, update, and validate commands, wiring it intoExportSinkSpecsink filter so operators can exclude standalone activity events while leaving workflow history export unchanged.On update, the flag is applied only when explicitly set (
Flags.Changed), so omitting it keeps the existing filter;--disable-standalone-activity-export=falsecan turn standalone activity export back on.Implementation refactors export sink create/update/validate: per-provider
Create*ExportSinkhelpers are removed in favor of inlined commandrunlogic usingGetCloudClient/GetPoller, and tests are consolidated into table-driven coverage across all three backends for filter, prompt, and API error paths.Reviewed by Cursor Bugbot for commit e05a976. Bugbot is set up for automated code reviews on this repo. Configure here.