Skip to content

Add support for disabling standalone activity export - #122

Open
david049 wants to merge 1 commit into
mainfrom
dliu/addsaaexportdisable
Open

david049 wants to merge 1 commit into
mainfrom
dliu/addsaaexportdisable

Conversation

@david049

@david049 david049 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

Adds support for disabling standalone activity export

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Note

Medium Risk
Changes what events are exported to customer-owned sinks and refactor export command paths; mis-handling the filter on update could silently change export behavior.

Overview
Adds --disable-standalone-activity-export to S3, GCS, and Azure Blob namespace export sink create, update, and validate commands, wiring it into ExportSinkSpec sink filter so operators can exclude standalone activity events while leaving workflow history export unchanged.

On update, the flag is applied only when explicitly set (Flags.Changed), so omitting it keeps the existing filter; --disable-standalone-activity-export=false can turn standalone activity export back on.

Implementation refactors export sink create/update/validate: per-provider Create*ExportSink helpers are removed in favor of inlined command run logic using GetCloudClient/GetPoller, and tests are consolidated into table-driven coverage across all three backends for filter, prompt, and API error paths.

Reviewed by Cursor Bugbot for commit e05a976. Bugbot is set up for automated code reviews on this repo. Configure here.

@david049
david049 requested a review from a team as a code owner November 3, 2026 21:00
@david049
david049 deployed to integration November 3, 2026 21:00 — with GitHub Actions Active
khisakuni
khisakuni previously approved these changes Nov 3, 2026

This branch is waiting to be deployed

1 waiting deployment
integration — e05a976d Waiting Nov 17, 2026 by david049 via Integration tests #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants