Repository navigation
Conversation
AsyncOperationPoller polled every second regardless of the flag, so namespace create and the other commands still on getPoller ignored --poll-interval. Pass the parsed interval through, reject non-positive values, and declare the flag on namespace edit, apply, delete and lifecycle set, which polled with the same poller without exposing it. Closes temporalio#121
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
AsyncOperationPollernow takes the poll interval instead of a fixed one second ticker, andgetPollerpasses the parsed--poll-intervalthrough for every command that still uses it:namespace create,retention set,export,connectivity,account audit-log sink,mtls cert-ca,mtls cert-filter,codecandsearch-attribute. A zero or negative interval returns an error instead of panicking intime.NewTicker.namespace edit,apply,deleteandlifecycle setpoll with the same poller but never declared the flag, so I addedpoll-intervalto them incommands.ymland ranmake gen.Why?
temporal cloud namespace create --poll-interval 7sstill checked the operation every second. Commands oncctx.GetPolleralready honor the flag; the oldergetPollerpath dropped it.Checklist
Closes [Bug] --poll-interval is ignored by namespace create and other commands using the shared poller #121
How was this tested:
New unit tests in
common_test.gocheck that status requests follow the configured interval and that zero or negative intervals error.go test ./...andmake genpass, and I checked--helpon the affected commands with the built binary.Any docs updates needed?
No. The flag text is unchanged; the four namespace commands now list
--poll-intervalin the generated reference.