Skip to content

Honor --poll-interval in the shared async operation poller - #128

Open
blacksoxx wants to merge 1 commit into
temporalio:mainfrom
blacksoxx:poll-interval-shared-poller
Open

blacksoxx wants to merge 1 commit into
temporalio:mainfrom
blacksoxx:poll-interval-shared-poller

Conversation

@blacksoxx

Copy link
Copy Markdown

What was changed

AsyncOperationPoller now takes the poll interval instead of a fixed one second ticker, and getPoller passes the parsed --poll-interval through for every command that still uses it: namespace create, retention set, export, connectivity, account audit-log sink, mtls cert-ca, mtls cert-filter, codec and search-attribute. A zero or negative interval returns an error instead of panicking in time.NewTicker.

namespace edit, apply, delete and lifecycle set poll with the same poller but never declared the flag, so I added poll-interval to them in commands.yml and ran make gen.

Why?

temporal cloud namespace create --poll-interval 7s still checked the operation every second. Commands on cctx.GetPoller already honor the flag; the older getPoller path dropped it.

Checklist

  1. Closes [Bug] --poll-interval is ignored by namespace create and other commands using the shared poller #121

  2. How was this tested:
    New unit tests in common_test.go check that status requests follow the configured interval and that zero or negative intervals error. go test ./... and make gen pass, and I checked --help on the affected commands with the built binary.

  3. Any docs updates needed?
    No. The flag text is unchanged; the four namespace commands now list --poll-interval in the generated reference.

AsyncOperationPoller polled every second regardless of the flag, so
namespace create and the other commands still on getPoller ignored
--poll-interval. Pass the parsed interval through, reject non-positive
values, and declare the flag on namespace edit, apply, delete and
lifecycle set, which polled with the same poller without exposing it.

Closes temporalio#121
@blacksoxx
blacksoxx requested a review from a team as a code owner November 12, 2026 11:16
@CLAassistant

CLAassistant commented Nov 12, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] --poll-interval is ignored by namespace create and other commands using the shared poller

2 participants