Repository navigation
fix(auth): username fallback never adopts local or LTI-native accounts (0.2.2) - #27
Merged
Merged
Conversation
…s (0.2.2) With OIDC_MATCH_BY_USERNAME_FALLBACK an IdP login could adopt a local break-glass superuser (no subject) or an LTI-native account (lti:...) that shared the username. The fallback now only matches accounts with an existing non-LTI OIDC subject, and logs each adoption at WARNING. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anlass
Security-Review von Abstimmbar vor 1.0: Mit `OIDC_MATCH_BY_USERNAME_FALLBACK=True` konnte ein IdP-Login ein lokales Konto ohne OIDC-Subject übernehmen – insbesondere den per `createsuperuser` angelegten Break-Glass-Admin. Analog LTI-native Konten (`lti::`).
Änderung
Tests
`python runtests.py`: 57 OK (4 neue: leeres/NULL-Subject, Superuser unangetastet, `lti:`-Subject, Log-Assertions).
Nach dem Merge bitte Tag `auth/v0.2.2` setzen (oder ich mache es nach Freigabe); Abstimmbar hebt den Pin in seinem Security-PR.
🤖 Generated with Claude Code