Repository navigation
Signal tool stability with waitForToolsUntil() and ToolChangeEvent - #373
Open
khushalsagar wants to merge 1 commit into
Open
khushalsagar wants to merge 1 commit into
khushalsagar wants to merge 1 commit into
Conversation
Collaborator
Author
|
A tangential thing worth taking up in a separate PR: the toolChange notification from register/unregister isn't coalesced well right now. It's triggered for every register/unregister call. Seems like it would be better to do it in a separate task (or microtask?) since in a task the state will be updated by multiple calls and we should dispatch a single event for all those mutations. |
khushalsagar
force-pushed
the
wait-for-tools-until
branch
2 times, most recently
from
November 3, 2026 20:26
94b382b to
9f62142
Compare
khushalsagar
force-pushed
the
wait-for-tools-until
branch
from
November 3, 2026 20:41
9f62142 to
59af1ff
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the resolution from #328 (minutes) and #328 (comment):
waitForToolsUntilandtoolsReady, and state tracking for thetools-readystate based on pending promises.tools-ready(up to an implementation-defined timeout) ingetTools()andperform an observation.toolchangeevent (ToolChangeEventwithready) when tools become not ready and suppress dispatch of this event until tools become ready again.Note: There's still an open question for the
Documentlifecycle until which tools are presumed to be not ready.Part of #328.
Preview | Diff