Repository navigation
Parse an IPv6 literal written inside brackets - #7
Merged
dominicletz merged 1 commit intoNov 2, 2026
Merged
Conversation
A URI authority and a Host header carry an IPv6 literal inside square brackets (RFC 3986 §3.2.2), and that is the form a caller holding an address taken from a URI has in hand. parse/1 answered nil on it, so every such caller had to strip the brackets itself, and the one who forgot dialed the wrong address family with no diagnostic. Only a v6 address is written that way: "[127.0.0.1]" stays nil, and so does a bracket that never closes.
This was referenced Aug 31, 2026
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is the form a URI authority and a
Hostheader carry an IPv6 literal in(RFC 3986 §3.2.2), so it is the form a caller holding an address taken from a
URI has in hand. Every such caller had to strip the brackets itself, and the one
who forgot dialed the wrong address family with no diagnostic — the address just
looked like a host name that does not resolve.
The new clause reads the reference and delegates to the existing parser. Only a
v6 address is written that way, so
"[127.0.0.1]"staysnil, and so does abracket that never closes.
Adds
test/ipv6_test.exswith one test, over both the accepted and the rejectedspellings.