Repository navigation
Notifier: name the force-cancel for a lost job GitHub keeps in progress - #50
Merged
Merged
Conversation
GitHub may keep a job in_progress after its Spot machine is gone: a re-run is refused and a plain cancel ends nothing, so "Re-run the job" alone can't be followed. The reclaim report's summary now gives the run's force-cancel, and warns that it ends the run's other running jobs too. The title is unchanged, since the notifier finds its reports by it. The runbook's "Read a lost job" and the traps table describe the stuck case. Closes #48 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…raps match it Review of #48: the summary's first instruction now reads "If the job failed, re-run it", so a reader in the stuck case doesn't meet the failing step first. stack.md's step 6 names the re-run and the force-cancel's warning; the traps row uses zeroae/<repo> as the runbook does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
Summary
A Spot reclaim can leave the lost job
in_progressafter its machine is gone. While it is stuck,gh run rerunis refused andgh run cancelends nothing. The reclaim check run's summary now names the step that works. Its title is unchanged, because the notifier finds its reports by that title.Docs:
docs/runbook.md: "Read a lost job" covers the stuck case.docs/traps.md: a new row for the symptom.docs/stack.md: step 6 matches the new summary.Evidence
a reclaim report tells how to unstick a lost job GitHub keeps in progressfails. The summary has nogh api -X POST repos/zeroae/app/actions/runs/444/force-cancel.After: it passes.
make testgives 183 pass, 0 fail.make buildgives 78001 of 1048576 bytes.133599865684stayedin_progressfrom 20:46:23 until it completed ascancelledat 21:01:02, the moment of the force-cancel.Merge Danger
Door: two-way
Only the text of new reclaim reports changes. Reports already on commits keep their old summary, and the title that skipping and clearing depend on is the same.
Blast Radius: wording
It takes effect after the next
make deploy.🤖 Generated with Claude Code