Repository navigation
Release copied rich text on source and file transitions - #188
Merged
Merged
Conversation
zzwong
force-pushed
the
dot/rich-cache-lifetime
branch
from
November 8, 2026 06:15
79a32c0 to
c21a173
Compare
zzwong
marked this pull request as ready for review
November 8, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Refs #71. RichCache owns copied prose independently of Snapshot. Source installation now invalidates it; changing files invalidates a cache whose snapshot/file differs while same-file selection preserves cached list state. Exactly three UI files, including the headless regression file; the earlier synthetic ownership probe is excluded.
Verification
Independent review clear. Two actual Workbench headless lifecycle tests pass: real rich rendering, source/file transition, replacement frames and weak payload ownership; same-file selection retains cache identity. UI lib/tests Clippy -D warnings, formatting and diff checks pass. Tests use offline services and GPUI TestAppContext, not a native GUI backend.
Limits
This addresses one bounded copied-text lifetime, not the historical cumulative growth or all of #71. No native RSS, GPU, M4, frame-pacing or speedup measurement. Revisiting rich content rebuilds its cache; native performance remains unqualified.