Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix native compiler selection in the benchmark driver for #115.
--ccand--cxxonce in the invoking environment and reuse absolute paths for preflight, build commands and metadata.Relative paths previously passed preflight in the checkout but failed after the driver switched to a disposable worktree. A compiler found through a relative PATH entry had the same problem. Default absolute compiler paths remain unchanged.
Validation
On Linux with Python 3.12.14 and Git 2.52.0:
7b68d0b6959607ff094745f8ab28a123ef2de2a8.The fixtures use real temporary Git worktrees and fake Rust/C/C++ executables. They execute the selected fake native compilers from the build working directory and compare them with the preflight receipts. Coverage includes relative paths, invocation outside the checkout, relative PATH entries, spaces, symlink names, symlink-plus-parent paths, missing/nonexecutable choices and absolute-path compatibility.
Unrun checks
Full repository core/native checks, real Rust/C/C++ compilation, Clippy/audit and native macOS checks were not run locally. No Rust toolchain was installed for this work. The focused fixtures do not establish native build compatibility or performance improvement; hosted CI is separate.
This is a standalone draft based directly on main. No application source, dependency, workflow, cache policy or profile default changed. #115 remains open for its broader measurement and platform acceptance.