Repository navigation
Conversation
Resolve omitted placement API origins through the bounded Core catalog. Validate session envelope repository identity before displaying context. Add native/mirror routing and identity regressions and document discovery.
Apply the nine formatting hunks reported by the required CI check. No behavior or fixture-response changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two focused fixes for the existing read-only Entire adapter:
apiBaseUrlis omitted. Read the authenticated Core cluster catalog, match a unique cluster slug before falling back to a whole cell host label, and validate the resulting API origin. Never choose the home/default region.repo_full_nameagainst the captured owner/repository or exact placement ULID before displaying session rows or claiming an empty range. Contradictory metadata leaves the diff usable with the existing unavailable notice.Catalog reads are bounded to 1 MiB and 1,024 rows. Invalid present inline URLs do not fall back. Duplicate mappings fail closed. Existing account, placement, immutable-revision and origin checks remain in place; capture rejects a changed final origin before contacting that replacement region.
Adds regression cases for both Entire-native and GitHub-mirror namespaces, normalized duplicate slugs, conflicting slug/cell matches, inline/catalog transitions, movement, cancellation, and session identity mismatches. No discussion UI, transcript fetching, write capability, dependency or workflow change is included.
Related: #175, #178, #179 and #182. This is partial support work; #178–182 remain open for their broader acceptance.
Contract references
Pinned to Entire CLI v0.12.2 (
c4f103d8dfed1f1549db9b2c793f2d7e10f65eb8):Validation completed
7b68d0b6959607ff094745f8ab28a123ef2de2a8.The Python checks qualify the fake responses only. They do not execute the Rust adapter, establish cancellation behavior, or validate a live Entire account.
Unrun checks
Rust compilation, unit/integration tests, rustfmt, Clippy, repository core/native checks and native GUI acceptance were not run locally. Cargo, rustc and rustfmt are unavailable in the assistant environment; no Rust toolchain was provisioned. No signed-in Entire service request was made. Hosted CI is separate and must pass for this exact head before merge.
Verification in a complete checkout
Use the repository's pinned Rust 1.99.0 toolchain:
Then qualify with the signed-in CLI and accessible test repositories:
entire version,curl --versionanddiffz --doctor; use the existing authorized login.etandghChange URLs, including a processing placement outside the account's home region and an Entire-only branch on a mirror. Verify the base/head and diff against Git, exact compact-JSON source bytes, reopen and persisted resume.apiBaseUrl, verify catalog routing reaches the processing placement. If all available responses include it, report that live case as unobserved; use the new fixtures for omitted/malformed/ambiguous mappings and routing transitions.--trail,--inspect, refresh/cancel and existing-window handoff on Linux/macOS as applicable. Record untested platforms and cases under Entire: qualify signed-in native/mirror workflows on Linux and macOS #182.Keep this draft until the Rust checks, required
check/nativeCI and applicable signed-in acceptance are recorded.