Repository navigation
Improve document status and handoff affordances - #124
Conversation
Update review handoff copy, default to suggesting mode, polish popover motion and arrows, and move save status into a fixed corner affordance.
Show copy previews in the document file menu and keep the menu open with temporary copied feedback after an action is selected.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 14a5ebe. Configure here.
| }: DocumentWorkspaceProps) { | ||
| const [documentInteractionMode, setDocumentInteractionMode] = | ||
| useState<DocumentInteractionMode>("editing"); | ||
| useState<DocumentInteractionMode>("suggesting"); |
There was a problem hiding this comment.
Default mode Suggesting not Editing
Medium Severity
The workspace initial documentInteractionMode state was changed from editing to suggesting, so every document opened through DocumentWorkspace now starts in Suggesting mode. That is not called out in the PR summary, and it conflicts with PageCard’s default of editing, so normal direct-editing sessions begin in track-changes-style suggesting unless the user switches modes manually.
Reviewed by Cursor Bugbot for commit 14a5ebe. Configure here.
Upstream Lex-Inc#124 padded the page 40px to make room for the fixed save-status corner. Remove the padding and sit the indicator on the toolbar row instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011xsXFrBAbhrvmZmhyCRVkG
* feat(app): refine document review controls Update review handoff copy, default to suggesting mode, polish popover motion and arrows, and move save status into a fixed corner affordance. * fix(app): truncate long suggestion summaries * feat(app): clarify document copy actions Show copy previews in the document file menu and keep the menu open with temporary copied feedback after an action is selected. * feat(app): clarify document copy actions * Improve review handoff sent state
Summary
This PR improves the document header affordances around saving, copying, and review handoff completion. It moves the save status into a fixed corner, adds a richer document copy menu with clean rich-text clipboard output, and makes unchanged documents use an
Approvehandoff label while changed documents still useI'm done. It also polishes the sent handoff popover with a completion title, robot high-five toy, fallback copy action, close-window action, and lets the mutedSentbutton reopen the popover without resubmitting. Tests cover the copy/menu behavior, handoff state transitions, sent-popover reopening, and screenshot guide expectations.Validation
pnpm checkpnpm test:smokeNote
Low Risk
Mostly UI and clipboard/handoff UX; handoff still saves before notify, with broad test coverage for copy stripping and state transitions.
Overview
Refines the document workspace around save status, copy, and review handoff completion.
Save status moves to a fixed top-left corner (
document-save-status-corner) instead of sitting beside the filename. The screenshot guide reflects that placement.File copy menu gains preview snippets per action, a longer “Copied!” state, and rich-text copy that strips critic markup (comments, additions, etc.) while producing cleaned HTML and plain text.
documentCopyPathis wired fromAppso “Copy path” uses the absolute file path.Review handoff shows Approve when the document is unchanged since open and I'm done after real edits (with a short grace period so initial dirty signals don’t flip the label). The success popover uses a random celebratory title,
RobotsHighFiveToy, fallback “copy a line for your agent” text, and Close window; the muted Sent primary button reopens the popover without resubmitting. Default interaction mode is now Suggesting.Smaller polish: tighter comment-thread layout in the rail, truncated long suggestion quotes in the review rail, narrower review rail width, popover open animation, plus unit/e2e tests and screenshot-guide updates.
Reviewed by Cursor Bugbot for commit 14a5ebe. Bugbot is set up for automated code reviews on this repo. Configure here.