Repository navigation
Conversation
This was referenced Nov 5, 2026
tnazarew
force-pushed
the
ci/pr-coverage
branch
from
November 12, 2026 13:16
0445bd7 to
8f79e0b
Compare
A green result has to mean the checks ran and passed.
Validator (scripts/validate_ol_events.py):
- Scenarios come from their definitions (valid for the validated
versions) plus the event directories, so a scenario without events is a
FAILURE ("scenario produced no events") instead of missing from the
report.
- A schema validator that raises fails that event's syntax test; before,
it returned None and the whole component's validation crashed with a
TypeError.
- An exception while validating one scenario (bad JSON, unreadable config)
fails only that scenario.
- Semantic checks skipped after a syntax failure get a SKIPPED note; a
version pair without any applicable semantic test gets a WARNING. Neither
makes a scenario red.
- --run_status <status.json>: a scenario whose producer job didn't end in
DONE gets a "producer job" FAILURE. This replaces check-spark-jobs, so the
signal is in the report.
- --openlineage_release: version gating when the spec tag isn't a version
(snapshots validate against main).
Workflows:
- Spark validates every pair whose jobs ran, even when another Spark
release's cluster failed; a pair that didn't run fails its validate job
without a report.
- Hive: the report was written as hive-dataproc--<ol>-report.json but
uploaded as hive-dataproc-<cv>-<ol>-report.json, so Hive results never
reached the report. Fixed, plus: installs its own requirements, a failed
query fails its scenario instead of aborting the pair, and the init
action reads GCS_TRANSPORT_JAR (it read GCS_TRANSPORT_JAR_URL and always
fell back to the 1.34.0 transport).
- Hive and dbt write status.json; report uploads fail when the report is
missing; the re-validation passes stored status.json files.
Hive expectations were stale (hardcoded cluster name, _producer pinned to
1.34.0, SQL formatting, an input location from an older query) and fail
today; they now match any Dataproc master and release. Dataset-level
transformations are compared unordered (1.34.0 and 1.55.0 emit them in a
different order), which needed a fix in compare_events: unordered_list
never matched, because the module's own any() jinja helper shadows the
builtin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
tnazarew
force-pushed
the
validation/no-false-greens
branch
from
November 12, 2026 13:16
0ca3298 to
0da89a4
Compare
Released transports-gcs 1.40.0-1.55.0 break Hive on Dataproc: the half-relocated Woodstox stops HiveServer2 from starting, and the bundled Conscrypt native library aborts the Tez application master. Now that the init action really installs the matching transport, the Hive 1.55.0 cluster can't start. Point the clusters at transports-gcs-1.56.0-SNAPSHOT-conscrypt-fix.jar, which has both problems fixed (verified: aggregate_job 10/10 on OpenLineage 1.34.0 and 1.55.0), and stop downloading and uploading the matching transport. Revert once a released transport has the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #352 (base
ci/pr-coverage); retarget tomainafter #352 merges.Why
A green result has to mean the checks ran and passed. Today several things pass silently:
hive-dataproc--<ol>-report.json(inputs.hive_releasedoesn't exist), the upload looks forhive-dataproc-<cv>-<ol>-report.jsonand only warns (e.g. run 42009167037).report.jsonhas nohive_dataprocentry, yet the job is green.GCS_TRANSPORT_JAR_URL, CI setsGCS_TRANSPORT_JAR, so every Hive run used the 1.34.0 GCS transport.None, the caller raisesTypeError, and the whole component's validation is lost.What
Validator
events: "scenario produced no events"validationfor that scenario onlyDONE(--run_status status.json)producer job: "producer job ended in state …, job '…'" (replacescheck-spark-jobs, so it's in the report)semanticsnotesemanticsSKIPPED/WARNING don't make a scenario red, aren't "new failures" and aren't counted in the compatibility tables (
report.pyonly looks at SUCCESS/FAILURE).--openlineage_releasegates versions when the spec tag ismain(snapshots).Workflows
validateruns for every pair whose jobs ran (!cancelled()), even if another Spark release's cluster failed. A pair withoutstatus.json, or where the runner failed before any scenario, fails its validate job without a report.check-spark-jobsremoved.producer/hive_dataproc/runner/requirements.txt(was Spark's); a failed query fails its scenario instead of aborting the pair; writesstatus.json; init action readsGCS_TRANSPORT_JAR(old name kept as fallback).status.json; every report upload usesif-no-files-found: error.status.json.Hive expectations were stale and fail today: hardcoded
hive-ol-cluster-m,_producerpinned totree/1.34.0, SQL whitespace, and an input location (gs://…/warehouse/transactions) from an older query.test.sqlcreates the table withoutLOCATION, so it lives in the cluster's HDFS warehouse. They now match any Dataproc master and release. Dataset-level transformations are compared unordered (1.34.0 emits[SORT, GROUP_BY], 1.55.0[GROUP_BY, SORT]). That needed a fix incompare_events.py:unordered_listnever matched, because the module's ownany()jinja helper shadows the builtin.Verification
pytest scripts/tests→ 43 passed. Written first against the old validator: 8 of the new validator tests failed for the expected reasons (TypeError crash, missing scenario, no note/warning, unknown options).main: 6/9 semantic tests failing at 1.55.0).DONE), old vs new validator: identical, 438 tests SUCCESS, no new failures vsreport.json.hive_releaseerror is gone).🤖 Generated with Claude Code