Skip to content

dbt: expect the current dataQualityAssertions shape - #357

Merged
tnazarew merged 1 commit into
mainfrom
dbt/fix-assertion-expectations
Nov 12, 2026
Merged

tnazarew merged 1 commit into
mainfrom
dbt/fix-assertion-expectations

Conversation

@tnazarew

@tnazarew tnazarew commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Why

The csv_to_postgres *_data_quality_assertions_test tests (added in #277) fail with OpenLineage 1.55.0. openlineage-dbt now emits the assertion type in assertion and the dbt test name in a new name field:

{"assertion": "not_null", "name": "not_null_stg_customers_customer_id", "column": "customer_id", "success": true, ...}

The expectations still have the test name in assertion. The release check hasn't published a dbt result since #277, so report.json has no baseline for these tests and every PR that runs dbt reports them as new failures (seen on #354 and #355).

What

The three expected data_quality_event.json files check the type in assertion and the test name in name. Order and entries are unchanged and match the emitted events one to one. dbt tests only the latest OpenLineage release (versions.json has no pinned OpenLineage versions), so there's no older shape to keep.

Verification

dbt events from a PR run (artifact dbt-1.8.0-1.55.0-events, run 42071091000), validated with main's validator and compared with report.json like the PR check does:

  • before: the three assertion tests FAILURE, the only new failures, exactly what the PR checks reported
  • after: all three SUCCESS, no new failures

This PR's own check runs dbt for real.

🤖 Generated with Claude Code

openlineage-dbt now puts the assertion type in "assertion" (not_null,
unique) and the dbt test name in a separate "name" field. The
csv_to_postgres expectations (#277) still had the test name in
"assertion", so the three *_data_quality_assertions tests fail with
OpenLineage 1.55.0. The release check hasn't published a dbt result since,
so report.json has no baseline for them and every PR that runs dbt sees
them as new failures.

The expectations now check both: the type in "assertion" and the test name
in "name". dbt tests only the latest OpenLineage release
(versions.json openlineage_versions is empty).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
@tnazarew
tnazarew force-pushed the dbt/fix-assertion-expectations branch from 1ce0a58 to dad8348 Compare November 12, 2026 11:39
@tnazarew
tnazarew marked this pull request as ready for review November 12, 2026 11:39
@tnazarew
tnazarew merged commit c7d0dbc into main Nov 12, 2026
11 checks passed
@tnazarew
tnazarew deleted the dbt/fix-assertion-expectations branch November 12, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant