Repository navigation
dbt: expect the current dataQualityAssertions shape - #357
Merged
Merged
Conversation
openlineage-dbt now puts the assertion type in "assertion" (not_null, unique) and the dbt test name in a separate "name" field. The csv_to_postgres expectations (#277) still had the test name in "assertion", so the three *_data_quality_assertions tests fail with OpenLineage 1.55.0. The release check hasn't published a dbt result since, so report.json has no baseline for them and every PR that runs dbt sees them as new failures. The expectations now check both: the type in "assertion" and the test name in "name". dbt tests only the latest OpenLineage release (versions.json openlineage_versions is empty). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
tnazarew
force-pushed
the
dbt/fix-assertion-expectations
branch
from
November 12, 2026 11:39
1ce0a58 to
dad8348
Compare
tnazarew
marked this pull request as ready for review
November 12, 2026 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
csv_to_postgres*_data_quality_assertions_testtests (added in #277) fail with OpenLineage 1.55.0.openlineage-dbtnow emits the assertion type inassertionand the dbt test name in a newnamefield:{"assertion": "not_null", "name": "not_null_stg_customers_customer_id", "column": "customer_id", "success": true, ...}The expectations still have the test name in
assertion. The release check hasn't published a dbt result since #277, soreport.jsonhas no baseline for these tests and every PR that runs dbt reports them as new failures (seen on #354 and #355).What
The three expected
data_quality_event.jsonfiles check the type inassertionand the test name inname. Order and entries are unchanged and match the emitted events one to one. dbt tests only the latest OpenLineage release (versions.jsonhas no pinned OpenLineage versions), so there's no older shape to keep.Verification
dbt events from a PR run (artifact
dbt-1.8.0-1.55.0-events, run 42071091000), validated withmain's validator and compared withreport.jsonlike the PR check does:This PR's own check runs dbt for real.
🤖 Generated with Claude Code