Repository navigation
Show a rejected plan as a plan to fix, not a platform fault (APT-1094) - #35
Merged
Merged
Conversation
A creation-plan validation that answers valid:false is an answer, not an outage. It gets its own class: no not-your-fault wording, no support reference, the reasons in the user's words (Platform's sentences verbatim when unknown), and the offered action leads to re-planning or to the destination re-binding; the rejected plan is never validated or executed again unchanged. Genuine request failures keep today's classes.
…plan failure (APT-1094)
…he user's plan problem (APT-1094) Only rejections whose meaning is known stay plan failures. An unknown valid:false answer keeps the platform class and its support reference, with two actions: check the same plan again (one validation per click) and make a new plan. A rejected plan is not validated or executed unchanged through an older retry notice; a limit refusal leaves no dead-end retry; a creationPlan mention in an HTTP failure no longer reclassifies it.
…creates (APT-1094) Review follow-ups. "Check again" runs its one validation from the click and no longer lifts the guard: a failed request leaves the plan rejected with nothing requested, so a reload sends nothing. A valid answer only makes the plan approvable again; nothing is created until the user approves. The legacy engine does not offer a re-check for a plan the conversation has outgrown, and its limit notice no longer points at the rejected proposal.
…t run, say when the plan is accepted (APT-1094)
Contributor
Author
|
Merging on the PO lead's decision (2026-11-15): four independent review rounds, the last two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
朝の 5 行(森さん向け)
8461c09)「マージしてよい。後続つき」→ 案 A で直した(546b269)→ 2 回目「変更が要る」(確かめ直しの依頼が失敗すると、断られた記録が消える)→ 直した(682e87c。あわせて、確かめ直しは作成に進まない / 古くなった計画には出さない)。3 回目(682e87c)「マージしてよい。後続つき」、止める指摘 0 件 → 利用者に見える小さな 3 点(名前の選び直しが出ない / 実行できないときに押すと知らせが消える / 通っても何も言わない)を直した(cd87ecc)。最後の差分の確認(cd87ecc)も「マージしてよい。後続つき」、止める指摘 0 件。残り(P3、後続の課題 APT-1108): 読み直すと名前の選び直しがまた出なくなる(もう一度確かめれば出る)/ 作成先が画面に無いときに押すと知らせが消える / 新しい方式で「受け付けられました」の知らせが、計画が古くなっても残る。 直していないもの: 新しい方式(console-v1)は、生成の上限を見分けられない(サーバーが理由を渡していない)ので、「計画を作り直す」が出たままになる。 確かめていないこと: 実環境の画面、ブラウザ。What (APT-1094, part of APT-1096)
github-template, fingerprintprepare()(for example the Retry of a destination stop met during a check) runs the check again, never an approval.retry('prepare')are guarded; older prepare notices show no action).failed_preconditionwithout Platform's reason, so 「計画を作り直す」 stays offered there (needs a server change).creationPlanmention reclassifies only a validation answer or a generation job's stored error, not an HTTP failure (5xx, 4xx) in the plan context.unavailable.For whoever merges second with #33
PlanValidationErrormeans only the Platform'svalid:falseanswer and is the only thing that marks a plan rejected. #33's stop for a blocking gate that is notreadymust be thrown as a different error (its own class or a plainError): it must not be remembered as a rejection, must not withdraw the create action, and must not go throughplanRejectionFailure(any line that function does not recognise becomes the platform failure with re-check). #33 also predates #30 and needs a rebase.Checks (on the committed tree, head
cd87ecc)bun run typecheck,bun run typecheck:e2e,bun test src(1976 pass, 0 fail),bun run check:response-boundaries(0 violations),bun run check:console-schema. Not run: mock stories locally (CI runs them), browser, live environment.