Skip to content

gatewayendpoint: treat a route-level Accepted=False as Unknown for DNS retention - #26

Merged
reoring merged 2 commits into
mainfrom
pubcont-s4-route-accepted-false-retention
Nov 13, 2026
Merged

reoring merged 2 commits into
mainfrom
pubcont-s4-route-accepted-false-retention

Conversation

@reoring

@reoring reoring commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Design: appthrust/platform ADR-0082, D4 (appthrust/platform#6682). Tracker: APT-827 (epic APT-819).

Do not merge or release yet (owner decision 2026-11-13: implement, do not deliver).

What

For DNS retention, a current route-level Accepted=False is treated exactly as Unknown: a hostname with a matching admission receipt is retained when the listener allows unknown retention. One condition changes in endpointRecordSetsForGateway.

Unchanged:

  • a new hostname is admitted only on a current Accepted=True;
  • receipt identity (Gateway UID and class, listener digest; a replacement route UID rebinds only when every current parentRef is Accepted=True);
  • Selector listeners retain neither Unknown nor False;
  • Gateway deletion and a Gateway-level Accepted=False withdraw the whole set;
  • hostname removal, parentRef removal and route deletion withdraw immediately;
  • last-known targets are kept while addresses are temporarily empty.

Why

On 2026-11-12 a management-cluster node roll and a release delivery each put a transient Accepted=False on every HTTPRoute of one Project. This controller deleted the EndpointRecordSet; 34 Route 53 records disappeared for two to three minutes, the names fell through to an estate wildcard and browsers reported ERR_CERT_COMMON_NAME_INVALID, while the load balancer and its targets stayed healthy. Route admission and policy staging control serving permission, not publication intent, and DNS withdrawal is not a security fence (the address stays reachable).

Tests

Failing before the change, passing after:

  • receipted hostname + route Accepted=False: EndpointRecordSet and child RecordSet UIDs unchanged, no provider DELETE (Gateway -> endpoint -> core composition -> Route 53 reconciler chain with an in-memory provider);
  • All, cross-namespace Same and Selector listeners;
  • unreceipted hostname is not added until Accepted=True;
  • hostname removal, parentRef removal, route deletion and replacement UID under False/Unknown withdraw;
  • Gateway-level Accepted=False withdraws a two-hostname set;
  • positive control: route deletion produces a provider DELETE.

TestGatewayEndpointRecordSetRevokesExplicitFalseAndForeignGateway/explicit false pinned the old behaviour and is replaced by the retention matrix; the remaining boundary cases are now TestGatewayEndpointRecordSetWithdrawalBoundaries.

go test ./internal/go/apps/gatewayendpoint/controllers/gateway -count=1: ok. Not verified against envtest, AWS or live DNS.

Consequence

A name can keep resolving while its route is closed; users then get the Gateway's HTTP response instead of a certificate error from another Gateway.

…S retention

A transient Accepted=False on every HTTPRoute of a Project (management
control-plane restart, policy staging) deleted the EndpointRecordSet and all
Route 53 records for two to three minutes while the data path stayed healthy.
Route admission controls serving, not publication intent: a receipted
hostname is now retained under the same boundary as Unknown. New hostnames
still require Accepted=True; identity, Gateway-level and intent-removal
withdrawals are unchanged. Design: appthrust/platform ADR-0082 D4.
@reoring

reoring commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

The platform design record was renumbered to ADR-0083; the doc link is updated. 'ADR-0082' in the description means ADR-0083.

@reoring reoring changed the title gatewayendpoint: treat a route-level Accepted=False as Unknown for DNS retention (do not merge yet) gatewayendpoint: treat a route-level Accepted=False as Unknown for DNS retention Nov 13, 2026
@reoring
reoring marked this pull request as ready for review November 13, 2026 01:39
@reoring

reoring commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Owner decision 2026-11-13: prepare delivery (merge and release); platform consumption still requires the reviewed-import approval in appthrust/platform.

@reoring
reoring merged commit f3316fc into main Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant