Repository navigation
gatewayendpoint: treat a route-level Accepted=False as Unknown for DNS retention - #26
Merged
Merged
Conversation
…S retention A transient Accepted=False on every HTTPRoute of a Project (management control-plane restart, policy staging) deleted the EndpointRecordSet and all Route 53 records for two to three minutes while the data path stayed healthy. Route admission controls serving, not publication intent: a receipted hostname is now retained under the same boundary as Unknown. New hostnames still require Accepted=True; identity, Gateway-level and intent-removal withdrawals are unchanged. Design: appthrust/platform ADR-0082 D4.
Contributor
Author
|
The platform design record was renumbered to ADR-0083; the doc link is updated. 'ADR-0082' in the description means ADR-0083. |
reoring
marked this pull request as ready for review
November 13, 2026 01:39
Contributor
Author
|
Owner decision 2026-11-13: prepare delivery (merge and release); platform consumption still requires the reviewed-import approval in appthrust/platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design: appthrust/platform ADR-0082, D4 (appthrust/platform#6682). Tracker: APT-827 (epic APT-819).
Do not merge or release yet (owner decision 2026-11-13: implement, do not deliver).
What
For DNS retention, a current route-level
Accepted=Falseis treated exactly asUnknown: a hostname with a matching admission receipt is retained when the listener allows unknown retention. One condition changes inendpointRecordSetsForGateway.Unchanged:
Accepted=True;Accepted=True);Selectorlisteners retain neitherUnknownnorFalse;Accepted=Falsewithdraw the whole set;Why
On 2026-11-12 a management-cluster node roll and a release delivery each put a transient
Accepted=Falseon every HTTPRoute of one Project. This controller deleted the EndpointRecordSet; 34 Route 53 records disappeared for two to three minutes, the names fell through to an estate wildcard and browsers reportedERR_CERT_COMMON_NAME_INVALID, while the load balancer and its targets stayed healthy. Route admission and policy staging control serving permission, not publication intent, and DNS withdrawal is not a security fence (the address stays reachable).Tests
Failing before the change, passing after:
Accepted=False: EndpointRecordSet and child RecordSet UIDs unchanged, no provider DELETE (Gateway -> endpoint -> core composition -> Route 53 reconciler chain with an in-memory provider);All, cross-namespaceSameandSelectorlisteners;Accepted=True;False/Unknownwithdraw;Accepted=Falsewithdraws a two-hostname set;TestGatewayEndpointRecordSetRevokesExplicitFalseAndForeignGateway/explicit falsepinned the old behaviour and is replaced by the retention matrix; the remaining boundary cases are nowTestGatewayEndpointRecordSetWithdrawalBoundaries.go test ./internal/go/apps/gatewayendpoint/controllers/gateway -count=1: ok. Not verified against envtest, AWS or live DNS.Consequence
A name can keep resolving while its route is closed; users then get the Gateway's HTTP response instead of a certificate error from another Gateway.