Repository navigation
hotfix: pin pytest below 9.2 in the test requirements (0.20.10) - #434
Open
JohnYanxinLiu wants to merge 1 commit into
Open
JohnYanxinLiu wants to merge 1 commit into
JohnYanxinLiu wants to merge 1 commit into
Conversation
pytest 9.2.0 stops at collection with an INTERNALERROR in tests/harness/collection.py:168, so the Python unit and harness contracts check failed on every pull request. Install pytest<9.2 until collection.py works with 9.2 and later. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins pytest below 9.2 in
tests/requirements.txt(VERSION → 0.20.10).tests/requirements.txtinstalls pytest unpinned, and pytest 9.2.0 stops at collection intests/harness/collection.py:168before any test runs. The "Python unit and harness contracts" check therefore fails on every pull request, and/pytestruns stop the same way.Cause.
modify_itemsincollection.pysetsitem._nodeid, which 9.2.0 no longer has. From the unit check of hotfix: pin MAVROS to 2.14.0 in the robot and GCS images (0.20.9) #433 (run 43959101341), which installed pytest 9.2.0:When. The last green unit run (2026-09-11, run 34567644887) used pytest 9.1.1.
Fix.
pytest→pytest<9.2intests/requirements.txt, and a dated 0.20.10 section in the release notes.collection.pyis not changed. The main → develop sync brings the pin intodevelop, which has the same line and the same unpinned pytest.Testing
The unit check on this PR installs from
tests/requirements.txton GitHub-hostedubuntu-latest, so its result is the test. The "Run Tests" system-test job needs a self-hosted runner and is not part of it.Follow-up
Make
collection.pywork with pytest 9.2 and later, then remove the pin.🤖 Generated with Claude Code