Repository navigation
Conversation
story_action_table() holds BDSP's story steps as one Pokemon::StoryActionTable: the walking kinds run StoryWalkSteps on the binding's StoryStepIO, and the kinds that need the console, plus every story event (by variant name), are the binding's own (StoryBoundActions). StoryExecutor is a TableExecutor with ConsoleStepGuard (the old run() guard: log line, reattempt line, screenshot, stop rows); SimExecutor is a TableExecutor over the same table with its stand-ins. Behavior is unchanged. The sim records each row's stubbed steps (stub_report()). New tests: every row's steps have an action, each (kind, variant) the story uses runs what the old dispatch ran, and every step the sim stubs needs the console. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss # Conflicts: # SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStory_Walk_Tests.cpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss # Conflicts: # SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStory_Walk_Tests.cpp
… the sim too run_into_door() and tap_to_banner() judge a warp's fade with WarpFadeWatch (DOOR_FADE_RULE, TAP_FADE_RULE: the same thresholds as their old watchers, now from BDSP_FADE_PROFILE), so a fade whose hold fell between two frames still shows, at the scene after the fall. The simulation emits a fade's frames (sim_fade_frames()) through the same watches, and SimMisses::hold drops one fade's hold: every row from 00.00 to 01.11 still passes with any one of them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…o bdsp/autostory-v4 # Conflicts: # SerialPrograms/Source/PokemonBDSP/Programs/AutoStory/PokemonBDSP_AutoStory_Walk_Tests.cpp # SerialPrograms/cmake/SourceFiles.cmake
…o bdsp/autostory-mine-floaroma-wip
…ostory-mine-floaroma-wip
GridSimRouteIO's taps now fill WalkResult::events from the leg's first tap: an encounter is recorded with record_tap_battle() at the tap that set it off (the one before, for a battle before its tap moved), and the taps that moved after it are counted, as the console's walk counts them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… screen events On below_roark's open leg east 14, a battle on tap 3, on tap 7 before it moved, and on the last tap: the leg's screen events must place the player within a tile or so of where the taps left them, and the step must still end below Roark. Red: the story's taps keep every tile of the leg after a battle, with no placement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
tap_legs() now reads the interrupted leg's timed events with place_leg_battle() and logs the verdict; a wild battle it places bounds the recovery's start to a tile or so from where the taps left the player (tiles_moved()) instead of every tile of the leg. Anything it cannot place (two battles, an UNSETTLED fade, no events) keeps the whole leg. Green: the open-leg battle sim test, on taps 3, 7 and 14 of east 14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…sp/autostory-mine-floaroma-wip
Brings in 9223d35, which registers the BDSP Dialog/Menu detector suites once; the runner aborted on Duplicate Test Name without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…carlo Picks up the single registration of the BDSP Dialog/Menu detector suites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
Picks up the single registration of the BDSP Dialog/Menu detector suites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
# Conflicts: # SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp
dayfine
added a commit
that referenced
this pull request
Nov 12, 2026
…er) into bdsp/start-certainty BDSP's robust routes now plan on Pokemon::plan_robust_legs. The held open legs this line added to BDSP's own planner (#375: hold_open_legs, per_open_grass_tile, open_hold_error(), TileLeg::held) move into the shared planner as RobustLegCosts::hold_open_legs / per_open_wild_tile and RobustLeg::held, off by default, so BDSP plans the same legs as before. SourceFiles.cmake keeps both sides' new files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The step came in with the bdsp/sim merge (#264) and was never on bdsp/autostory-v4. v4 rewrote StoryData/*.plan.json in the #312 format: steps carry action + args, poses are {map, facing, tiles}, and the file has a metadata block. No PokemonSimulation revision reads that format (913a5e3 and main 438b672 both reject the top-level keys, and pose and step shapes differ too), so the step could only fail. The workflow now matches bdsp/autostory-v4; restore the replay once the simulator reads the v4 plan format, with a new pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…_name) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… on literal temporaries) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…table_step, stray using namespace detail) and header_symbols tag on RouteTiming.h Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ion templates The AutoStoryResources test found 22 Autostory/Options PNGs missing in CI: they are not in PokemonAutomation/Packages master. dayfine/Packages bdsp/autostory-options is upstream master plus exactly those files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…story table route_plans.golden.txt and PlanGolden.h predated the merge: they lacked 00.02 to_the_lake_entrance, 00.05b past_the_president, 01.02 south_to_the_cliff and 01.08 west_to_the_wall, and still stored 00.01 onto_the_flute_tile. Both tests fail identically on macOS with the CI-pinned maps, so this is not CI data. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…osts The queue compared costs only, so equal-cost spreads came off the heap in the standard library's order: macOS planned 'north 1; west 2; south 1' round a wander zone and Ubuntu 'south 1; west 2; north 1'. Equal costs now go to the lesser spread (north to south, west to east). A second case pins the east side. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Folded leaf PR #168; tree equals the leaf tip. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This was referenced Nov 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Conflict in PokemonBDSP_AutoStory_Walk_Tests.cpp includes: keep this branch's story headers; #128's added Utils/Walk.h include was already present.
dayfine
added a commit
that referenced
this pull request
Nov 17, 2026
dayfine
added a commit
that referenced
this pull request
Nov 17, 2026
Conflict in PokemonBDSP_AutoStory_Walk_Tests.cpp includes: drop the duplicate Utils/Walk.h include, as #375 resolved it.
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #148 (base
bdsp/actions-v4); folds in #128 (new game to Floaroma as one story table, merged in), so the diff shows #128 and this stage. The older #262, #311 and #400 still stack on it.This is the BDSP console stage from Oreburgh to Floaroma, folded from #167 (grid simulation of walks and scenes), #226 (Oreburgh Mine alignment, corridor legs, Floaroma pathing, the shared action table and between-step interrupts), #364 (settle after every way through instead of fixed waits) and #375 (short door settle in Centers, one run to the nurse); those PRs are closed and keep their discussion. It now carries #128's seam work (StoryRun shell, start gate, golden plans, fault sweeps); where a BDSP plan file conflicted it keeps the version console B runs on
lab/dev-bdsp, and each merge commit lists those decisions. Two pieces of our own code moved, unchanged, to keep files under the 1000-line limit: the story sim's trigger tables toSimTriggers.cppand the simulated-console route tests toSimulatedRoute_Tests.cpp(git diff --color-moved 0405c90e5~1 0405c90e5and the same for 3521c81). Tested with the headless runner onlab/dev-bdsp(153e32f), which merges this branch through #400:PokemonBDSP::AutoStorygives 353 passed / 10 failed, the same nine known failures as before (seven Monte Carlo rows, the old 01.03 and the hand-written-legs list) plus #128's new "fault sweep: every story route with timed holds overshooting", which the console-run plans do not pass yet.