Skip to content

PLZA AutoStory: confirm talks, A prompt as control, carried-over autosave badge - #629

Closed
dayfine wants to merge 1 commit into
plza/port-original-0308-0311from
plza/talk-confirm
Closed

dayfine wants to merge 1 commit into
plza/port-original-0308-0311from
plza/talk-confirm

Conversation

@dayfine

@dayfine dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Based on plza/port-original-0308-0311 (#623); the diff shows only this change.

Run 12 (German, console B, 2026-11-16) showed three problems. 02.05's talk pressed A the instant the walk reached the elevator, the game dropped it, and text_to_choice then read the overworld for 120 s. The talk now presses only on a prompt seen on two looks in a row, presses A again while the prompt stays up with nothing open (3 As at most), and fails with a clear message after that. The walk control check missed 01.03 and Hotel Z because the party bar detector reads the bar's D-pad arrows, which show only with 2+ Pokemon, so an A prompt held a second with nothing busy now counts as control. 02.04's autosave badge was still up on 02.05's first look and was counted as 02.05's save, which forced a backup rewind. A badge within 5 s of one seen before the checkpoint started now counts as the earlier save.

Tested with new and updated AutoStoryGame unit tests (talk, walk control, autosave sightings); CI runs them.

…ve badge

- talk_at_prompt(): A only on the A prompt seen on two looks in a row;
  while the prompt stays up with nothing open, A again every second, 3 As
  at most, then talk_no_scene. 02.05's elevator A was lost the instant the
  walk ended and the next step read the overworld for 120 s.
- check_can_walk(): an A prompt held a second with nothing busy is
  control. The party bar reads by its D-pad arrows, which show only with
  2+ Pokemon, so 01.03 (no party) and Hotel Z (one) waited 10 s of quiet.
- AutosaveSightings: a badge within 5 s of one seen before the checkpoint
  started is that earlier save. 02.04's check-in badge, still up on 02.05's
  first look, made 02.05's failure rewind to the backup save.
@dayfine

dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #644 (one lean branch; split for review later)

@dayfine dayfine closed this Nov 17, 2026
@dayfine
dayfine deleted the plza/talk-confirm branch November 17, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant