Repository navigation
Conversation
…ve badge - talk_at_prompt(): A only on the A prompt seen on two looks in a row; while the prompt stays up with nothing open, A again every second, 3 As at most, then talk_no_scene. 02.05's elevator A was lost the instant the walk ended and the next step read the overworld for 120 s. - check_can_walk(): an A prompt held a second with nothing busy is control. The party bar reads by its D-pad arrows, which show only with 2+ Pokemon, so 01.03 (no party) and Hotel Z (one) waited 10 s of quiet. - AutosaveSightings: a badge within 5 s of one seen before the checkpoint started is that earlier save. 02.04's check-in badge, still up on 02.05's first look, made 02.05's failure rewind to the backup save.
Owner
Author
|
Superseded by #644 (one lean branch; split for review later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on plza/port-original-0308-0311 (#623); the diff shows only this change.
Run 12 (German, console B, 2026-11-16) showed three problems. 02.05's talk pressed A the instant the walk reached the elevator, the game dropped it, and text_to_choice then read the overworld for 120 s. The talk now presses only on a prompt seen on two looks in a row, presses A again while the prompt stays up with nothing open (3 As at most), and fails with a clear message after that. The walk control check missed 01.03 and Hotel Z because the party bar detector reads the bar's D-pad arrows, which show only with 2+ Pokemon, so an A prompt held a second with nothing busy now counts as control. 02.04's autosave badge was still up on 02.05's first look and was counted as 02.05's save, which forced a backup rewind. A badge within 5 s of one seen before the checkpoint started now counts as the earlier save.
Tested with new and updated AutoStoryGame unit tests (talk, walk control, autosave sightings); CI runs them.