Repository navigation
Conversation
… and talks - PartySlotsDetector: the party bar's last slot as an empty frame (a light line, the scene darkened inside) is PLAYER_CAN_MOVE too, for a party of 1 to 5. The bar's D-pad arrows show only with 2+ Pokemon, so 02.05's lobby start (German, one Pokemon) waited 10 s of quiet. - Walks to an A prompt (end "prompt", walk_to_prompt) end on it only when it shows again on a look 300 ms later, the stick let go; else they walk on. 02.05's walk to the elevator ended on a first glimpse. - talk_at_prompt() waits up to 3 s (was 1 s) for the prompt on two looks in a row; "A Aufzug nehmen" stood steady a few seconds after the talk gave up with talk_no_prompt. - CI pin: dayfine/CommandLineTests plza/party-slots (the two 02.05 frames).
…ted none The elevator frame has the party bar of one (a Pokemon and five empty slot frames). The case expected no bar while the bar was read only by its D-pad arrows; PartySlotsDetector now reads it, as it should.
Owner
Author
|
Superseded by #644 (one lean branch; split for review later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #629 (base
plza/talk-confirm; the diff shows only this change).Run 13 (German, console B, 2026-11-16) failed 02.05 at the elevator. The lobby start waited 10 s of quiet: with one Pokemon the party bar shows no D-pad arrows, the only thing the control check looked for. Then the walk ended on a first glimpse of the A prompt, and the talk gave up after 1 s with
talk_no_prompt, though "A Aufzug nehmen" stood steady a few seconds later.This change:
PartySlotsDetector, which reads the party bar's last slot as an empty frame. That slot's frame now counts as PLAYER_CAN_MOVE too, so a party of 1 to 5 shows control.walk_to_prompt) only when the prompt shows again 300 ms later. Otherwise they walk on.talk_no_prompt.Testing:
plza/party-slots.