Skip to content

PLZA AutoStory: party bar by its empty slot, steady prompts for walks and talks - #630

Closed
dayfine wants to merge 2 commits into
plza/talk-confirmfrom
plza/prompt-steady
Closed

dayfine wants to merge 2 commits into
plza/talk-confirmfrom
plza/prompt-steady

Conversation

@dayfine

@dayfine dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Depends on #629 (base plza/talk-confirm; the diff shows only this change).

Run 13 (German, console B, 2026-11-16) failed 02.05 at the elevator. The lobby start waited 10 s of quiet: with one Pokemon the party bar shows no D-pad arrows, the only thing the control check looked for. Then the walk ended on a first glimpse of the A prompt, and the talk gave up after 1 s with talk_no_prompt, though "A Aufzug nehmen" stood steady a few seconds later.

This change:

  • Adds PartySlotsDetector, which reads the party bar's last slot as an empty frame. That slot's frame now counts as PLAYER_CAN_MOVE too, so a party of 1 to 5 shows control.
  • Ends walks to a prompt (end "prompt" and walk_to_prompt) only when the prompt shows again 300 ms later. Otherwise they walk on.
  • Makes the talk wait up to 3 s for a steady prompt before it fails talk_no_prompt.

Testing:

  • New AutoStoryGame run cases cover a glimpse that goes again and a prompt that comes up 2 s into the talk. The run cases with prompt walks now expect the 300 ms confirm look.
  • AutoStoryScreenEvents frame cases cover the two 02.05 frames and Wild Zone 1's road.
  • The AutoStoryDetectors folder tests now check that the slot reading stays off on all 686 cutscene frames of 01.00-01.03.
  • The CI pin moves to dayfine/CommandLineTests plza/party-slots.

… and talks

- PartySlotsDetector: the party bar's last slot as an empty frame (a
  light line, the scene darkened inside) is PLAYER_CAN_MOVE too, for a
  party of 1 to 5. The bar's D-pad arrows show only with 2+ Pokemon, so
  02.05's lobby start (German, one Pokemon) waited 10 s of quiet.
- Walks to an A prompt (end "prompt", walk_to_prompt) end on it only when
  it shows again on a look 300 ms later, the stick let go; else they walk
  on. 02.05's walk to the elevator ended on a first glimpse.
- talk_at_prompt() waits up to 3 s (was 1 s) for the prompt on two looks
  in a row; "A Aufzug nehmen" stood steady a few seconds after the talk
  gave up with talk_no_prompt.
- CI pin: dayfine/CommandLineTests plza/party-slots (the two 02.05 frames).
…ted none

The elevator frame has the party bar of one (a Pokemon and five empty
slot frames). The case expected no bar while the bar was read only by its
D-pad arrows; PartySlotsDetector now reads it, as it should.
@dayfine

dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #644 (one lean branch; split for review later)

@dayfine dayfine closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant