Skip to content

PLZA 03.11: drop the forced reload when chained - #636

Closed
dayfine wants to merge 4 commits into
plza/patrol-overshootfrom
plza/0311-facing
Closed

dayfine wants to merge 4 commits into
plza/patrol-overshootfrom
plza/0311-facing

Conversation

@dayfine

@dayfine dayfine commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Depends on #637 (base plza/patrol-overshoot; the diff shows only this change).

03.11 forced a reload when chained from 03.10 (reload_when_chained "always") because its walk was measured from the reloaded autosave's facing. A chained run that first turned right 90° failed (console B, 2026-11-17 01:25), and the user judged that chained and reloaded runs can take the same legs, so 03.11 now just runs on from the live screen. With 03.04 and 03.11 dropped, no plan uses "always", so it goes along with the "skip forced reloads" developer option and the now-unused StoryRows parameter of run_plza_segments()/run_plza_with_rewinds().

Testing: PLZA AutoStoryGame run/chain tables and the shared StoryFiles tables, on Fork Draft CI. A chained 03.11 is still to be verified on console.

RunState gets row_start (LOADED or CHAINED): run_plza_segments() sets
CHAINED when a row goes on from the live screen; a reload or retry resets
the state to LOADED. A walk's new arg "first_turn_when_chained" adds a
turn-only leg before its legs on a CHAINED start and logs which way it
went.

03.11's to_mable turns right 90 degrees when chained (the user,
2026-11-17), to be verified on console, and drops reload_when_chained
"always". No plan uses "always" any more, so it is removed with the
developer option "skip forced reloads" (SegmentRunOptions::ForcedReloads)
and the unused StoryRows parameter of run_plza_segments() and
run_plza_with_rewinds().
A chained 03.11 run that turned right 90 degrees first failed to reach
Mable (console B 2026-11-17 01:25), and the user judged the turn
unneeded: chained and reloaded runs take the same legs. Drops the walk
arg "first_turn_when_chained", RunState::row_start and their tests; the
forced-reload removal stays.
@dayfine dayfine changed the title PLZA 03.11: turn right when chained instead of a forced reload PLZA 03.11: drop the forced reload when chained Nov 17, 2026
…0311-facing

# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/PokemonLZA_AutoStoryGame_Tests.cpp
@dayfine
dayfine changed the base branch from plza/scene-advance-a to plza/patrol-overshoot November 17, 2026 09:57
@dayfine

dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #644 (one lean branch; split for review later)

@dayfine dayfine closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant