Repository navigation
Conversation
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 113182a. Configure here.
|
bugbot run |
AIConfig.variation is optional. When it is omitted, run() evaluates the
config for {kind: "evaluation", key: <evaluation key>} and uses that
variation's _ldMeta.version. A missing version is an error before any write.
Co-authored-by: Dylan O'Neill <donei003@users.noreply.github.com>
An omitted variation evaluates the AI Config through extract_variation, which initializes the SDK with no options. Resolve the client first so the evaluations sdk_key is used, as the judge path already does. Co-authored-by: Dylan O'Neill <donei003@users.noreply.github.com>
donei003
force-pushed
the
cursor/eval-served-variation-700b
branch
from
November 16, 2026 20:28
99223f9 to
3074240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
#277 is on main. This PR targets main. The diff is only this change. Draft.
AIConfig.variationis optional.keyis an error before any network call. feat(evaluations): reconcile offline evaluations by key #277 already rejects it; this PR pins""and whitespace, including whenvariationis omitted.variationis set, the base is still that variation's latest management-API version. The flag is not evaluated.variationis omitted,run()callsextract_variationwith{kind: "evaluation", key: <evaluation key>}. There is no caller context and no project-key fallback._ldMeta.version. The version-1 default insideextract_variationis not used. A missing or non-integer version, includingTrue, is anEvaluationsErrorbefore any write.EvaluationsErrorbefore any write.result.urlis unchanged:{ui}/projects/{project}/ai/evaluations/{evaluationId}/runs/{runId}.configKey,variationKey, andvariationVersionare the next PR in this stack.Decisions
Parameter overrides still merge key by key, as they do today. A key the caller sets wins, and other parameter keys stay. That is the layering already applied on top of a variation.
Testing
2221 passed.
packages/client/api-report/launchdarkly_ai_server.txtis regenerated forAIConfig.variation: str | None = None.